Skip to content

Application Gateway WAF policy workbook #3047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 16, 2025

Conversation

NiviShenker
Copy link
Contributor

@NiviShenker NiviShenker commented Jun 10, 2025

Summary

Added AppGW WAF workbook, will be exposed to appGW WAF customers from the portal from "Insights" and "Workbooks" blades.

Screenshots

  • If you added a template to a gallery, show a screenshot of it in the gallery view (which verifies its shows up where you expected).
    image

image
It is also good to show a screenshot of template content, so people can see what you expect it to look like, compared to what they see when they might run it themselves.

Validation

  • Validate your changes using one or more of the testing methods.

    Make sure you've tested your template content. Fixing things while in PR is trivial. Hotfixing it later is very expensive; at the current time at least 3 teams are involved in a hotfix!

Checklist

  • If you are adding a new template, gallery, or folder, add your team and folder/file(s) to the CODEOWNERS file at the root of the repo. CODEOWNERS entries should be teams, not individuals.
    When done correctly, this means that from then on your team does reviews of your things, not the workbooks team.
  • Ensure all steps in your template have meaningful names.
  • Ensure all parameters and grid columns have display names set so they can be localized.

@NiviShenker NiviShenker requested review from a team as code owners June 10, 2025 15:46
"categories": [
{
"id": "WAFPolicyWorkbooks",
"name": "Network Insights WAF Policy",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want a different name for the category/group it shows up under?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is the category we want but changed the WB name

{
"id": "Workbooks/Network Insights/ApplicationGatewayWebApplicationFirewallPolicies/AppGwWafDefault",
"author": "Microsoft",
"name": "Network Insights WAF Policy"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best practice: there's an optional description field here to explain what it is / what it does

@NiviShenker NiviShenker merged commit f70e185 into master Jun 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants