-
Notifications
You must be signed in to change notification settings - Fork 487
Application Gateway WAF policy workbook #3047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"categories": [ | ||
{ | ||
"id": "WAFPolicyWorkbooks", | ||
"name": "Network Insights WAF Policy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want a different name for the category/group it shows up under?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is the category we want but changed the WB name
{ | ||
"id": "Workbooks/Network Insights/ApplicationGatewayWebApplicationFirewallPolicies/AppGwWafDefault", | ||
"author": "Microsoft", | ||
"name": "Network Insights WAF Policy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
best practice: there's an optional description
field here to explain what it is / what it does
Summary
Added AppGW WAF workbook, will be exposed to appGW WAF customers from the portal from "Insights" and "Workbooks" blades.
Screenshots
It is also good to show a screenshot of template content, so people can see what you expect it to look like, compared to what they see when they might run it themselves.
Validation
Validate your changes using one or more of the testing methods.
Make sure you've tested your template content. Fixing things while in PR is trivial. Hotfixing it later is very expensive; at the current time at least 3 teams are involved in a hotfix!
Checklist
When done correctly, this means that from then on your team does reviews of your things, not the workbooks team.