-
Notifications
You must be signed in to change notification settings - Fork 114
Merge master to staging branch #1972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Set up CI with Start Right * get the pr pipeline main file updated * rename nuget script * change direct files * change name * change buildandtest * Update CsWinRT-PR-Pipeline.yml for Azure Pipelines * change to build plat * Change to build platform * fix nuget * fix publish nuget * pool type error * add it back in * new change * change * change * change * change * Fixes * More changes * More changes * Fixes * Attempt fix * Try to fix * More fixes * Remove xlang signing * Fix pipeline * Fix * Remove dotnet installation * Cleanup * Get latest * Fix build * Fix runtimeidentifier * Try removing local appdata * Try another fix * Try another fix * Try another fix * Check path * Test * test * Test * Fix * Again * Test * Fix * try again * experiement * One more * Revert "Fix runtimeidentifier" This reverts commit 3d7449b. * Try fix * Move around * Test * Try again * Test * Test * Try to fix * Cleanup * Fix * Try to fix * Convert to pipeline task * Fix * fix restore * restore * fix typo * fix dependency * Logging * Fix * Try fix * experiment * Try developer mode * Try * Move * Try fix * Fix * Try to fix * Fix * Fix * Fix * test * try 2 * test * Test * test * test * test * fix * test * test * test * Fix * Fix * debug * Fix official * Fix * Fix * Fix test * Fix signing * Test to confim fixed * run * Fix * Fix * Test * Fix * test * Fix * Fix * Fix * Fix pool * Collections * authenticate * Revert "Fix pool" This reverts commit 00ade74. * Fix * Fix * Fix * Use parameters * Fix * Fix * Try * test * Revert "test" This reverts commit d510b42. * Revert "Try" This reverts commit e64185b. * Revert "Fix" This reverts commit d4695bc. * Revert "Fix" This reverts commit 1a1cc97. * Revert "Use parameters" This reverts commit 9b0d590. * Fix * Revert "Collections" This reverts commit f706525. * Fix collections test * Fixes * Fix * Cleanup * Add PR pipeline * Refactor to support github * More fixes * Fix * Move around * Fix * Add release pipeline * Try scoping * Fixes * Fix * Fix * Fix * Fix * Fix * Test * Fix * Try to fix * Revert * Experiment * Test * Fix * Fixed * Rename * Fix --------- Co-authored-by: Sophia Chen <sophchen@microsoft.com> Co-authored-by: Sophia Chen <sophia.six.chen@gmail.com>
* Fix signing so that it happens in the same pipeline it is built. * Updated CsWinRT-BuildAndTest-Stage-OneBranch.yml
Central package management
* Experiment with build * Revert
…ed before returned KeyValuePair (#1967)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 55 out of 59 changed files in this pull request and generated 2 comments.
Files not reviewed (4)
- .config/tsaoptions.json: Language not supported
- build/AzurePipelineTemplates/CsWinRT-BuildAndTest-Stage.yml: Language not supported
- build/AzurePipelineTemplates/CsWinRT-PublishToNuget-Stage.yml: Language not supported
- src/Authoring/WinRT.SourceGenerator/WinRT.SourceGenerator.props: Language not supported
Comments suppressed due to low confidence (1)
build/AzurePipelineTemplates/CsWinRT-Build-Steps.yml:216
- [nitpick] Verify if restricting the staging of CsWinRT artifacts to only x86 release builds is intended, as previous logic allowed other configurations.
condition: and(succeeded(), and(eq(variables['BuildPlatform'], 'x86'), eq(variables['BuildConfiguration'], 'release')))
|
||
Write-Host ##vso[task.setvariable variable=PATH;]${env:Agent_TempDirectory}\procdump;${env:PATH}; | ||
|
||
# Use .NET Core runtme 3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in comment: 'runtme' should be corrected to 'runtime'.
# Use .NET Core runtme 3.1 | |
# Use .NET Core runtime 3.1 |
Copilot uses AI. Check for mistakes.
@@ -10,52 +10,35 @@ steps: | |||
script: get_testwinrt.cmd | |||
workingDirectory: $(Build.SourcesDirectory)\src | |||
|
|||
# Use .NET Core SDK 3.1 | |||
# Use .NET Core runtme 3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in comment: 'runtme' should be corrected to 'runtime'.
# Use .NET Core runtme 3.1 | |
# Use .NET Core runtime 3.1 |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since this is just a merge of pipeline changes into a staging branch.
No description provided.