-
Notifications
You must be signed in to change notification settings - Fork 539
Downgrade HL7 SDK v5 to v4 for STU3, R4, and R4B #4988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mikaelweave
wants to merge
29
commits into
main
Choose a base branch
from
personal/mikaelw/firely-downgrade-split
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.Health.Fhir.Core/Features/Definition/CompartmentDefinitionManager.cs
Fixed
Show fixed
Hide fixed
src/Microsoft.Health.Fhir.Core/Features/Definition/SearchParameterDefinitionManager.cs
Fixed
Show fixed
Hide fixed
...crosoft.Health.Fhir.Core/Features/Search/Registry/FilebasedSearchParameterStatusDataStore.cs
Fixed
Show fixed
Hide fixed
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Azure API for FHIR
Label denotes that the issue or PR is relevant to the Azure API for FHIR
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
Bug
Bug bug bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Downgrade Firely Packages for STU3, R4, and R4B Due to Performance Issues
Summary
This PR downgrades the Firely (HL7.Fhir) packages for the STU3, R4, and R4B FHIR versions. The change is necessary due to significant performance regressions observed with the newer package versions—specifically, a 2.8x increase in CPU consumption during typical workloads.
Details
Rationale
Recent benchmarks revealed that the latest Firely packages introduce unacceptable CPU overhead, impacting server scalability and cost. Until these issues are resolved upstream, we are reverting to the previous, more performant versions for the affected FHIR versions.
Testing
Related issues
AB#154845
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)