Bulk-update #5022
Open
Bulk-update #5022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update # Conflicts: # src/Microsoft.Health.Fhir.Core/Features/Operations/JobRecordProperties.cs
src/Microsoft.Health.Fhir.CosmosDb/Features/Storage/Queues/CosmosQueueClient.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Shared.Api/Controllers/BulkUpdateController.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Data/OperationDefinition/bulk-update.json
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Features/Operations/BulkUpdate/BulkUpdateOrchestratorJob.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Features/Operations/BulkUpdate/BulkUpdateOrchestratorJob.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Features/Operations/BulkUpdate/BulkUpdateOrchestratorJob.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Features/Operations/BulkUpdate/BulkUpdateOrchestratorJob.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Features/Operations/BulkUpdate/BulkUpdateProcessingJob.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Features/Operations/BulkUpdate/BulkUpdateProcessingJob.cs
Show resolved
Hide resolved
|
|
||
| namespace Microsoft.Health.Fhir.Core.Features.Operations | ||
| { | ||
| public class CustomFhirJsonSerializer<T> : ICustomFhirJsonSerializer<T> |
There was a problem hiding this comment.
Why is this class needed instead of using the existing resource serializer and deserializer?
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlQueueClient.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlQueueClient.cs
Outdated
Show resolved
Hide resolved
…update # Conflicts: # src/Microsoft.Health.Fhir.Core/Resources.resx # src/Microsoft.Health.Fhir.Shared.Web/appsettings.json
LTA-Thinking
reviewed
Jul 8, 2025
src/Microsoft.Health.Fhir.Core/Features/Operations/BulkUpdate/Handlers/GetBulkUpdateHandler.cs
Show resolved
Hide resolved
LTA-Thinking
reviewed
Jul 8, 2025
LTA-Thinking
reviewed
Jul 8, 2025
LTA-Thinking
reviewed
Jul 9, 2025
apurvabhaleMS
added
New Feature
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| Target = ResourceElement | ||
| .Select(Operation.Path) | ||
| .RequireOneOrMoreElements() | ||
| .RequireMultipleElementsInSameCollection() |
There was a problem hiding this comment.
What does this line do that means we have to get the target a second time?
There was a problem hiding this comment.
I checked in new code. But this line will only allow multiple elements if they are a collection and are from the same collection
...icrosoft.Health.Fhir.Core/Features/Operations/BulkUpdate/Handlers/CancelBulkUpdateHandler.cs
Outdated
Show resolved
Hide resolved
...ft.Health.Fhir.Core.UnitTests/Features/Operations/BulkUpdate/CancelBulkUpdateHandlerTests.cs
Show resolved
Hide resolved
...osoft.Health.Fhir.Core.UnitTests/Features/Operations/BulkUpdate/GetBulkUpdateHandlerTests.cs
Show resolved
Hide resolved
| } | ||
| }); | ||
| } | ||
| else if (definition.IsParallel) |
There was a problem hiding this comment.
This case isn't rerun safe. If the orchestrator job crashes in the middle of executing it may create multiple identical processing jobs.
src/Microsoft.Health.Fhir.Core/Features/Operations/BulkUpdate/BulkUpdateProcessingJob.cs
Show resolved
Hide resolved
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/BulkUpdateTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/BulkUpdateTests.cs
Outdated
Show resolved
Hide resolved
…update # Conflicts: # src/Microsoft.Health.Fhir.Core/Features/Operations/JobRecordProperties.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the $bulk-update operation. PATCH$bulk-update
This operation can be called at the system level or the resource type level.
As with our other async jobs it returned a Content-Location header showing the endpoint where the job record can be retrieved from. This endpoint can be used to get the current status of the job (GET) or to cancel it (DELETE).
This job is limited by the integer max value due to reporting the ids of deleted resources. This means that jobs should be limited to impact no more than ~2 billion resources, probably less than 500 million to be safe.
Added to capabilities statement.
Added notification on job competition.
Added unit tests.
Rest examples added
Supports the following parameters:
_isParallel: Flag for whether to run subjobs parallely. Default true.
: Any parameters used for a normal search operation can be added.
Related issues
Addresses AB146980.
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)