Bulk Delete: Remove references #5027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 23, 2025 15:06
added 2 commits
June 18, 2025 08:06
feordin
reviewed
Jun 18, 2025
src/Microsoft.Health.Fhir.Shared.Core/Features/Resources/Delete/ReferenceRemover.cs
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+19
to
+35
| foreach (var child in namedChildren) | ||
| { | ||
| var childValue = child.Value; | ||
| if (childValue.TypeName == "Reference") | ||
| { | ||
| var reference = (ResourceReference)childValue; | ||
| if (reference.Reference.Contains(target, StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| reference.Reference = null; | ||
| reference.Display = "Referenced resource deleted"; | ||
| } | ||
| } | ||
| else if (childValue.Children.Any()) | ||
| { | ||
| RemoveReference(childValue, target); | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 2 months ago
To fix the issue, we will replace the foreach loop on line 19 with a LINQ Select transformation. This will map namedChildren to a sequence of child.Value objects, which can then be iterated over directly. The rest of the loop logic remains unchanged. This approach improves readability by explicitly separating the transformation step from the iteration logic.
Changes required:
- Replace the
foreachloop to iterate overnamedChildren.Select(child => child.Value). - Ensure no other parts of the code depend on the original
childvariable, as it will no longer be available.
Suggested changeset
1
src/Microsoft.Health.Fhir.Shared.Core/Features/Resources/Delete/ReferenceRemover.cs
| @@ -18,5 +18,4 @@ | ||
| var namedChildren = resource.NamedChildren; | ||
| foreach (var child in namedChildren) | ||
| foreach (var childValue in namedChildren.Select(child => child.Value)) | ||
| { | ||
| var childValue = child.Value; | ||
| if (childValue.TypeName == "Reference") |
Copilot is powered by AI and may make mistakes. Always verify output.
LTA-Thinking
added
Enhancement
rbans96
previously approved these changes
Jul 7, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mikaelweave
approved these changes
Jul 11, 2025
|
Reviewed merge commit - approved on top of last approval. |
rbans96
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a parameter to bulk-delete to allow for the removal of references to deleted resources.
Related issues
Addresses User Story 139078
Testing
New and existing tests
FHIR Team Checklist
Semver Change (docs)
Patch