Skip to content

MergeResources concurrent call return 429 #5029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rbans96
Copy link
Contributor

@rbans96 rbans96 commented Jun 19, 2025

Description

Raise 429 errors if MergeResources concurrent calls is above optimal. Also add retryAfter header to suggest the backoff.

Related issues

Addresses [issue #].

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@rbans96 rbans96 requested a review from a team as a code owner June 19, 2025 16:27
@rbans96 rbans96 added the Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs label Jun 19, 2025
@rbans96 rbans96 added this to the CY25Q2/2Wk06 milestone Jun 19, 2025
@rbans96 rbans96 added the Enhancement Enhancement on existing functionality. label Jun 19, 2025
@rbans96 rbans96 changed the title Personal/ribans/mergeresources return 429 MergeResources concurrent call return 429 Jun 19, 2025
@rbans96 rbans96 force-pushed the personal/ribans/mergeresources-return-429 branch from cf421f3 to 3549127 Compare June 19, 2025 18:59
mikaelweave
mikaelweave previously approved these changes Jun 19, 2025
Copy link
Contributor

@mikaelweave mikaelweave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@rbans96
Copy link
Contributor Author

rbans96 commented Jun 19, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement Enhancement on existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants