-
Notifications
You must be signed in to change notification settings - Fork 153
[BICEP] Add support for custom resource naming in FinOps Toolkit #1635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Co-authored-by: flanakin <399533+flanakin@users.noreply.github.com>
Co-authored-by: flanakin <399533+flanakin@users.noreply.github.com>
Co-authored-by: flanakin <399533+flanakin@users.noreply.github.com>
src/templates/finops-hub/main.bicep
Outdated
storageAccountName: storageAccountName | ||
dataFactoryName: dataFactoryName | ||
keyVaultName: keyVaultName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the parameter pass-through in main.bicep (commit 66f9c8f)
src/templates/finops-hub/main.bicep
Outdated
@description('Optional. Custom name for the Storage Account. If not provided, a name will be generated based on the hub name. Must follow Azure Storage naming rules.') | ||
param storageAccountName string = '' | ||
|
||
@description('Optional. Custom name for the Data Factory. If not provided, a name will be generated based on the hub name. Must follow Azure Data Factory naming rules.') | ||
param dataFactoryName string = '' | ||
|
||
@description('Optional. Custom name for the Key Vault. If not provided, a name will be generated based on the hub name. Must follow Azure Key Vault naming rules.') | ||
param keyVaultName string = '' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the custom resource naming parameters in main.bicep (commit 66f9c8f)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this file as requested (commit 66f9c8f)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this file as requested (commit 66f9c8f)
Co-authored-by: flanakin <399533+flanakin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot You reverted too much. The storage, ADF, and Key Vault names should be specified in hub.bicep and passed down to hub-app.bicep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've restored the storage, ADF, and Key Vault name parameters in hub.bicep and hub-app.bicep while ensuring they're properly passed through the module chain. The parameters are now available in hub.bicep and passed down to hub-app.bicep as requested (commit 3cb5af8).
…icep Co-authored-by: flanakin <399533+flanakin@users.noreply.github.com>
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Overview
This PR adds support for custom resource naming in the FinOps Toolkit Bicep deployment, allowing organizations to follow their naming standards when deploying FinOps resources.
Changes Made
storageAccountName
: Custom name for the Storage AccountdataFactoryName
: Custom name for the Data FactorykeyVaultName
: Custom name for the Key VaultExample Usage
With these changes, consumers can specify their own resource names:
Or use a company naming module:
Backward Compatibility
All parameters have empty string defaults, ensuring backward compatibility with existing deployments. When a parameter is not specified, the resource name is generated using the original logic based on the hub name.
Fixes #1105.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.ms
bicep build src/templates/finops-hub/main.bicep
(dns block)bicep build src/templates/finops-hub/modules/hub-types.bicep
(dns block)bicep build src/templates/finops-hub/modules/hub-app.bicep
(dns block)app.aladdin.microsoft.com
/usr/bin/../../opt/az/bin/python3 -Im azure.cli bicep build --file src/templates/finops-hub/main.bicep --force
(dns block)cdn.fwupd.org
/usr/bin/fwupdmgr refresh
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.