Start Data Explorer when stopped #1637
Conversation
… down #1371 and updating documentation
microsoft-github-policy-service
bot
added
the
Needs: Review 👀
| typeProperties: { | ||
| method: 'POST' | ||
| url: { | ||
| value: '@if(equals(variables(\'dataExplorerStatus\'),\'Stopped\'),\'${environment().resourceManager}/subscriptions/${subscription().subscriptionId}/resourceGroups/${resourceGroup().name}/providers/Microsoft.Kusto/clusters/${dataExplorerCluster.name}/start?api-version=2024-04-13\',\'${environment().resourceManager}/subscriptions/${subscription().subscriptionId}/resourceGroups/${resourceGroup().name}/providers/Microsoft.Kusto/clusters/${dataExplorerCluster.name}/start?api-version=2024-04-13\')\n \n\n ' |
There was a problem hiding this comment.
Am I missing something or is this if() block setting the same value in both conditions? Is that intentional? If so, it seems like we don't need an if() block, right?
| value: '@if(equals(variables(\'dataExplorerStatus\'),\'Stopped\'),\'${environment().resourceManager}/subscriptions/${subscription().subscriptionId}/resourceGroups/${resourceGroup().name}/providers/Microsoft.Kusto/clusters/${dataExplorerCluster.name}/start?api-version=2024-04-13\',\'${environment().resourceManager}/subscriptions/${subscription().subscriptionId}/resourceGroups/${resourceGroup().name}/providers/Microsoft.Kusto/clusters/${dataExplorerCluster.name}/start?api-version=2024-04-13\')\n \n\n ' | |
| value: '@if(equals(variables(\'dataExplorerStatus\'),\'Stopped\'),\'${environment().resourceManager}${dataExplorerCluster.id}/start?api-version=2024-04-13\',\'${environment().resourceManager}${dataExplorerCluster.id}/start?api-version=2024-04-13\')' |
There was a problem hiding this comment.
yes it is intentional at the time being as the if clause is expecting a value for the false case. I could not yet determine a good alternative "Post" command to be executed if the the status of the cluster is stopped. Additionally same as above, the API URL is in the expected format
There was a problem hiding this comment.
What happens if we attempt to start a running cluster? Does it fail or does it noop? I'm guessing it succeeds and does nothing. If so, we could just always attempt to start the cluster and leave it at that.
Perhaps a bigger question is, what happens if starting fails? Do we need to loop to wait for the cluster to start? Do we need to try again if it fails?
There was a problem hiding this comment.
I redefined the validation by the following:
- attempt to start the cluster
- the only errors where we have to do a restart are if the cluster is in a not defined state (while starting or stopping),
- if so we wait and attempting a new start of the cluster
- if this still not work, then we post the error
flanakin
changed the title
There was a problem hiding this comment.
Don't forget to update the changelog
There was a problem hiding this comment.
sure, will be added after all comments are resolved in this PR
DataExplorer status check and start description for the ingestion_ExecuteETL pipeline Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
DataExplorer Identity role assignment, adjustment to adhere to Naming conventions Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
remove spaced Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
rename adxStatus variable to adhere to naming conventions Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
change activity name to adhere to naming conventions Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
activity name changed to adhere to naming conventions Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
remove of parameter as not needed Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
remove additional variable to track ADX deployment as an existing one can be used for this Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
Adjust of Activity name to adhere to naming conventions Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
remove parameter for Data Explorer deployment validation as now backed into directly Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
change activity name to adhere to naming conventions Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
Fixes #1371 start ADX cluster when it is stopped
📷 Screenshots
added new if activity to check status with web activity to check cluster and to start if necessary
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?