Skip to content

Correctly detect the hub version in the Data Ingestion power bi reports and update the json schema for this config #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

JacobStruiksma
Copy link

@JacobStruiksma JacobStruiksma commented Jun 4, 2025

🛠️ Description

Correctly detect the hub version in the Data Ingestion power bi reports and update the json schema for this config. Otherwise hub version 0.10 and higher would incorrectly marked as InvalidHubVersion

Fixes #1660

📷 Screenshots

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

cannot find the file?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@microsoft-github-policy-service microsoft-github-policy-service bot added Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed labels Jun 4, 2025
@JacobStruiksma
Copy link
Author

JacobStruiksma commented Jun 4, 2025

@microsoft-github-policy-service agree company="KPN"

@flanakin flanakin added this to the 2025-06 - June milestone Jun 4, 2025
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JacobStruiksma This is perfect! Can you also update the changelog? Everything else looks great!

@flanakin
Copy link
Collaborator

@allcontributors please add @JacobStruiksma for code

Copy link
Contributor

@flanakin

I've put up a pull request to add @JacobStruiksma! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finops hub version 0.10 not recognized as a valid hub version
4 participants