Skip to content

feat(warehouse_snapshot): onboard new warehouse snapshot DS and RS #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(warehouse_snapshot): onboard new warehouse snapshot DS and RS #483

wants to merge 7 commits into from
+1,561 −0

Conversation

catalina-gav
Copy link
Contributor

@catalina-gav catalina-gav commented Jun 4, 2025 •
edited
Loading

BLOCKED

📥 Pull Request

Close #484
Close #485

❓ What are you trying to address

Onboard new fabric_warehouse_snapshot data source and resource

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025 •
edited
Loading

Changelog Preview

v1.4.1-dev - August 12, 2025

✨ Added

  • #484 Onboard new fabric_warehouse_snapshot Data Source
  • #485 Onboard new fabric_warehouse_snapshot Resource

@catalina-gav
Copy link
Contributor Author

This is currently BLOCKED due to API issues.

@catalina-gav catalina-gav changed the title feat(warehouse_snapshot) : onboard new warehouse snapshot DS and RS feat(warehouse_snapshot): onboard new warehouse snapshot DS and RS Jun 4, 2025
@OrBaubergMicrosoft
Copy link
Collaborator

just figured out that warehouse snapshot has updateable properties
image
@badeamarjieh @DariuszPorowski
let's have a discussion offline on design,
what should we do if updateable properties are a of the initial config (creation payload) vs not a part of it

Catalina Gavrilovici (QUALITEST) added 2 commits August 5, 2025 11:02
@catalina-gav catalina-gav marked this pull request as ready for review August 5, 2025 11:09
@Copilot Copilot AI review requested due to automatic review settings August 5, 2025 11:09
@catalina-gav catalina-gav requested a review from a team as a code owner August 5, 2025 11:09
Copilot
Copilot AI reviewed Aug 5, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR onboards a new warehouse snapshot data source and resource to the Fabric Terraform provider. The implementation adds support for managing and querying warehouse snapshots, which are point-in-time copies of Microsoft Fabric data warehouses.

  • Adds fabric_warehouse_snapshot resource for creating and managing warehouse snapshots
  • Adds fabric_warehouse_snapshot and fabric_warehouse_snapshots data sources for querying warehouse snapshots
  • Includes comprehensive test coverage for both unit and acceptance tests

Reviewed Changes

Copilot reviewed 29 out of 30 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/testhelp/fakes/fake_server.go Registers warehouse snapshot entity handler in fake server
internal/testhelp/fakes/fabric_warehouse_snapshot.go Implements fake server operations for warehouse snapshot testing
internal/services/warehousesnapshot/* Core implementation files for warehouse snapshot resource and data sources
internal/provider/provider.go Registers new warehouse snapshot resource and data sources with provider
examples/* Terraform configuration examples for warehouse snapshot usage
docs/* Generated documentation for warehouse snapshot resource and data sources
.changes/unreleased/* Changelog entries for the new features

OrBaubergMicrosoft
OrBaubergMicrosoft reviewed Aug 7, 2025
View reviewed changes
internal/services/warehousesnapshot/resource_warehouse_snapshot_test.go
map[string]any{
"workspace_id": workspaceID,
"display_name": entityCreateDisplayName,
"configuration": map[string]any{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check that the parent_warehouse_id is the one you gave it,
you can try to create with snapshot_date_time (how do you saw time.now in golang? and check that the time you sent is the one you got :)

OrBaubergMicrosoft
OrBaubergMicrosoft reviewed Aug 7, 2025
View reviewed changes
tools/scripts/Set-WellKnown.ps1 Outdated
@@ -1744,4 +1744,4 @@ $wellKnown['Subfolder'] = @{
# Save wellknown.json file
$wellKnownJson = $wellKnown | ConvertTo-Json -Depth 10
$wellKnownJson
$wellKnownJson | Set-Content -Path './internal/testhelp/fixtures/.wellknown.json' -Force -NoNewline -Encoding utf8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what is the diff here, do you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrBaubergMicrosoft OrBaubergMicrosoft

Copilot code review Copilot

At least 1 approving review is required to merge this pull request.

Assignees

@catalina-gav catalina-gav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RS] Add warehouse snapshot resource [DS] Add warehouse snapshot data-source
2 participants
@catalina-gav @OrBaubergMicrosoft