Fix missing return statements after error handling in datasources (#827)

* Initial plan for issue

* Fix missing return statements after error handling in three datasources

Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>

* Add changelog entry for error handling fixes

Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>
Co-authored-by: Matt Dotson <mattdot@users.noreply.github.com>

Author: 3 people

.changes/unreleased/fixed-20250604-175056.yaml

@@ -0,0 +1,5 @@
+kind: fixed
+body: Fixed missing return statements after error handling in three datasources to prevent potential panics and undefined behavior
+time: 2025-06-04T17:50:56.587490569Z
+custom:
+    Issue: "814"

internal/services/application/datasource_tenant_application_packages.go

@@ -171,7 +171,11 @@ func (d *TenantApplicationPackagesDataSource) Read(ctx context.Context, req data
 	defer exitContext()
 
 	var state TenantApplicationPackagesListDataSourceModel
-	resp.State.Get(ctx, &state)
+	diags := resp.State.Get(ctx, &state)
+	resp.Diagnostics.Append(diags...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
 
 	state.Name = types.StringValue(state.Name.ValueString())
 	state.PublisherName = types.StringValue(state.PublisherName.ValueString())
@@ -213,7 +217,7 @@ func (d *TenantApplicationPackagesDataSource) Read(ctx context.Context, req data
 		state.Applications = append(state.Applications, app)
 	}
 
-	diags := resp.State.Set(ctx, &state)
+	diags = resp.State.Set(ctx, &state)
 
 	resp.Diagnostics.Append(diags...)
 	if resp.Diagnostics.HasError() {

internal/services/connectors/datasource_connectors.go

@@ -123,6 +123,7 @@ func (d *DataSource) Read(ctx context.Context, req datasource.ReadRequest, resp
 	connectors, err := d.ConnectorsClient.GetConnectors(ctx)
 	if err != nil {
 		resp.Diagnostics.AddError(fmt.Sprintf("Client error when reading %s", d.FullTypeName()), fmt.Errorf("error occurred: %w", err).Error())
+		return
 	}
 
 	for _, connector := range connectors {

internal/services/solution/datasource_solutions.go

@@ -134,6 +134,7 @@ func (d *DataSource) Read(ctx context.Context, req datasource.ReadRequest, resp
 	dvExits, err := d.SolutionClient.DataverseExists(ctx, state.EnvironmentId.ValueString())
 	if err != nil {
 		resp.Diagnostics.AddError(fmt.Sprintf("Client error when checking if Dataverse exists in environment '%s'", state.EnvironmentId.ValueString()), err.Error())
+		return
 	}
 
 	if !dvExits {