Skip to content

Commit 3b114c9

Browse files
Copilotmawasilemattdot
authored
Replace magic strings with constants in hash_test.go for better maintainability (#829)
* Initial plan for issue * Replace magic strings with constants in hash_test.go Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com> * Remove changelog file as requested Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com> Co-authored-by: Matt Dotson <mattdot@users.noreply.github.com>
1 parent 971df8e commit 3b114c9

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

internal/helpers/hash_test.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,24 +13,29 @@ import (
1313
func TestUnitCalculateSHA256(t *testing.T) {
1414
t.Parallel()
1515

16+
const (
17+
sameContent = "same"
18+
differentContent = "different"
19+
)
20+
1621
tdir := t.TempDir()
1722
file1 := tdir + "/test.txt"
1823
file2 := tdir + "/test2.txt"
1924
file3 := tdir + "/test3.txt"
2025
file4 := tdir + "/test4.txt"
2126
file5 := tdir + "/test5"
2227

23-
err := os.WriteFile(file1, []byte("same"), 0644)
28+
err := os.WriteFile(file1, []byte(sameContent), 0644)
2429
if err != nil {
2530
t.Fatal(err)
2631
}
2732

28-
err = os.WriteFile(file2, []byte("same"), 0644)
33+
err = os.WriteFile(file2, []byte(sameContent), 0644)
2934
if err != nil {
3035
t.Fatal(err)
3136
}
3237

33-
err = os.WriteFile(file3, []byte("different"), 0644)
38+
err = os.WriteFile(file3, []byte(differentContent), 0644)
3439
if err != nil {
3540
t.Fatal(err)
3641
}

0 commit comments

Comments
 (0)