Fix type safety and formatting issues in provider code (#844)

* Initial plan for issue

* Fix Issue 1: Add string length validation to billing policy required fields

Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>

* Fix Issue 2: Update UrlFormatError to use pointer receiver for future-proofing

Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>

* Fix Issue 3: Fix escaped newlines in UUID error message constants

Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>

* Add changelog entry for type safety and formatting fixes

Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>
Co-authored-by: Matt Dotson <mattdot@users.noreply.github.com>

Author: 3 people

.changes/unreleased/fixed_type_safety_formatting_issues.yaml

@@ -0,0 +1,4 @@
+kind: fixed
+body: Fixed type safety and formatting issues including missing string validation, interface assertions, and escaped newline formatting
+custom:
+  Issue: 825

internal/api/client_test.go

@@ -39,10 +39,10 @@ func TestUnitApiClient_GetConfig(t *testing.T) {
 	}
 
 	switch err.(type) {
-	case customerrors.UrlFormatError:
+	case *customerrors.UrlFormatError:
 		return
 	default:
-		t.Errorf("Expected error type %s but got %s", reflect.TypeOf(customerrors.UrlFormatError{}), reflect.TypeOf(err))
+		t.Errorf("Expected error type %s but got %s", reflect.TypeOf(&customerrors.UrlFormatError{}), reflect.TypeOf(err))
 	}
 }
 

internal/customerrors/url_format_error.go

@@ -7,21 +7,21 @@ import (
 	"fmt"
 )
 
-var _ error = UrlFormatError{}
+var _ error = (*UrlFormatError)(nil)
 
 type UrlFormatError struct {
 	Url string
 	Err error
 }
 
 func NewUrlFormatError(url string, err error) error {
-	return UrlFormatError{
+	return &UrlFormatError{
 		Err: err,
 		Url: url,
 	}
 }
 
-func (e UrlFormatError) Error() string {
+func (e *UrlFormatError) Error() string {
 	errorMsg := ""
 	if e.Err != nil {
 		errorMsg = e.Err.Error()
@@ -30,6 +30,6 @@ func (e UrlFormatError) Error() string {
 	return fmt.Sprintf("Request url must be an absolute url: '%s' : '%s'", e.Url, errorMsg)
 }
 
-func (e UrlFormatError) Unwrap() error {
+func (e *UrlFormatError) Unwrap() error {
 	return e.Err
 }

internal/customtypes/uuid_value.go

@@ -18,7 +18,7 @@ import (
 
 const (
 	UUIDTypeErrorInvalidStringHeader  = "Invalid UUID String Value"
-	UUIDTypeErrorInvalidStringDetails = `A string value was provided that is not valid UUID string format.\n\nGiven Value: %s\n`
+	UUIDTypeErrorInvalidStringDetails = "A string value was provided that is not valid UUID string format.\n\nGiven Value: %s\n"
 )
 
 var (

internal/services/licensing/resource_billing_policy.go

@@ -68,10 +68,16 @@ func (r *BillingPolicyResource) Schema(ctx context.Context, req resource.SchemaR
 			"name": schema.StringAttribute{
 				MarkdownDescription: "The name of the billing policy",
 				Required:            true,
+				Validators: []validator.String{
+					stringvalidator.LengthAtLeast(1),
+				},
 			},
 			"location": schema.StringAttribute{
 				MarkdownDescription: "The location of the billing policy",
 				Required:            true,
+				Validators: []validator.String{
+					stringvalidator.LengthAtLeast(1),
+				},
 				PlanModifiers: []planmodifier.String{
 					stringplanmodifier.RequiresReplace(),
 				},
@@ -98,13 +104,19 @@ func (r *BillingPolicyResource) Schema(ctx context.Context, req resource.SchemaR
 					"resource_group": schema.StringAttribute{
 						MarkdownDescription: "The resource group of the billing instrument",
 						Required:            true,
+						Validators: []validator.String{
+							stringvalidator.LengthAtLeast(1),
+						},
 						PlanModifiers: []planmodifier.String{
 							stringplanmodifier.RequiresReplace(),
 						},
 					},
 					"subscription_id": schema.StringAttribute{
 						MarkdownDescription: "The subscription id of the billing instrument",
 						Required:            true,
+						Validators: []validator.String{
+							stringvalidator.LengthAtLeast(1),
+						},
 						PlanModifiers: []planmodifier.String{
 							stringplanmodifier.RequiresReplace(),
 						},