Configuration and Constants Issues (#838)

* Initial plan for issue

* Fix configuration and constants issues: CAE challenge strings, RX domain constants, and AuxiliaryTenantIDs type safety

Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>

* Add changelog entry for configuration and constants fixes

Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>

* Update internal/provider/provider.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Revert RX PowerApps Advisor API domain constants to eaglex.ic.gov

Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Matt Dotson <mattdot@users.noreply.github.com>

Author: 4 people

.changes/unreleased/fixed-20250605-121743.yaml

@@ -0,0 +1,5 @@
+kind: fixed
+body: 'Fix configuration and constants issues: CAE challenge detection strings, RX PowerApps Advisor API domain constants, and AuxiliaryTenantIDs type safety conversion'
+time: 2025-06-05T12:17:43.646455328Z
+custom:
+    Issue: "824"

internal/api/client.go

@@ -83,8 +83,8 @@ func IsCaeChallengeResponse(resp *http.Response) bool {
 	if resp.StatusCode == http.StatusUnauthorized {
 		wwwAuthenticate := resp.Header.Get("WWW-Authenticate")
 		if wwwAuthenticate != "" {
-			return strings.Contains(wwwAuthenticate, "claims=") &&
-				strings.Contains(wwwAuthenticate, "insufficient_claims")
+			return strings.Contains(wwwAuthenticate, constants.CAE_CHALLENGE_CLAIMS_INDICATOR) &&
+				strings.Contains(wwwAuthenticate, constants.CAE_CHALLENGE_INSUFFICIENT_CLAIMS_INDICATOR)
 		}
 	}
 

internal/constants/constants.go

@@ -188,6 +188,10 @@ const (
 	NO_MANAGEMENT_APPLICATION_ERROR_MSG = "authorization has been denied for this request. Make sure that your service principal is registered as an admin management application: https://learn.microsoft.com/en-us/power-platform/admin/powerplatform-api-create-service-principal#registering-an-admin-management-application"
 )
 
+const (
+	CAE_CHALLENGE_CLAIMS_INDICATOR              = "claims="
+	CAE_CHALLENGE_INSUFFICIENT_CLAIMS_INDICATOR = "insufficient_claims"
+)
 // Error codes for provider errors.
 const (
 	ERROR_OBJECT_NOT_FOUND             = "OBJECT_NOT_FOUND"

internal/provider/provider.go

@@ -355,7 +355,11 @@ func configureUseMsi(ctx context.Context, p *PowerPlatformProvider, clientId str
 	// Convert the slice to an array
 	auxiliaryTenantIDsList := make([]string, len(auxiliaryTenantIDs.Elements()))
 	for i, v := range auxiliaryTenantIDs.Elements() {
-		auxiliaryTenantIDsList[i] = v.String()
+		if str, ok := v.(types.String); ok {
+			auxiliaryTenantIDsList[i] = str.ValueString()
+		} else {
+			tflog.Warn(ctx, fmt.Sprintf("Element at index %d in auxiliaryTenantIDs is not of type types.String. Skipping.", i))
+		}
 	}
 	p.Config.AuxiliaryTenantIDs = auxiliaryTenantIDsList
 	p.Config.UseMsi = true