Enhance test assertion failure messages with actual/expected values

[Copilot]

The test functions in internal/provider/provider_test.go were using generic failure messages that made debugging difficult when assertions failed. This change replaces the generic messages with descriptive ones that include actual and expected values.

Changes Made

Before:

require.Equal(t, len(expectedDataSources), len(datasources), "There are an unexpected number of registered data sources")
require.Contains(t, expectedDataSources, d(), "An unexpected data source was registered")

After:

require.Equalf(t, len(expectedDataSources), len(datasources), "Expected %d data sources, got %d", len(expectedDataSources), len(datasources))
require.Containsf(t, expectedDataSources, d(), "Data source %+v was not expected", d())

Impact

When tests fail, developers will now see specific information like:

• "Expected 25 data sources, got 24" instead of "There are an unexpected number of registered data sources"
• "Data source {TypeName: example} was not expected" instead of "An unexpected data source was registered"

This provides immediate context about what went wrong, making debugging much faster and more efficient.

Fixes #802.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• checkpoint-api.hashicorp.com
  • Triggering command: /tmp/go-build1791408922/b001/provider.test -test.testlogfile=/tmp/go-build1791408922/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true -test.run=TestUnit.* (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[mawasile]

@copilot add changelog

[Copilot]

Pull Request Overview

This PR improves test failure messages by incorporating actual and expected values into assertion errors.

• Test assertions in provider_test.go now use require.Equalf and require.Containsf with formatted messages
• Error messages reveal specific discrepancies in data sources and resources counts

Comments suppressed due to low confidence (2)

internal/provider/provider_test.go:81

• [nitpick] Consider rephrasing the error message to clarify that the data source was expected but not found; for example, 'Data source %+v not found in expected data sources' may improve readability.

require.Containsf(t, expectedDataSources, d(), "Data source %+v was not expected", d())

internal/provider/provider_test.go:113

• [nitpick] Consider rephrasing the error message to better indicate that the resource was expected to be present but was missing; for example, 'Resource %+v not found in expected resources' would be clearer.

require.Containsf(t, expectedResources, r(), "Resource %+v was not expected", r())

[Copilot]

@copilot add changelog

Added changelog entry in commit 6da0aa4. The change is categorized as a documentation improvement since it enhances test debugging visibility.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• http://168.63.129.16:80/machine/
  • Triggering command: /usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list