Validation and Modifiers Issues #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@copilot read the issue and validate if it was already fix if not then fix it. don't forget to run linter, tests and changie |
Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>
Co-authored-by: mawasile <50197777+mawasile@users.noreply.github.com>
I have successfully fixed all 8 issues identified in #821. The changes include:
All linting passes, unit tests for the affected services pass, documentation has been regenerated, and a changie entry has been created. The fix is complete in commit 7bf68e2. |
Copilot finished work on behalf of
mawasile
June 5, 2025 10:29
|
@copilot change the pr title, its still WIP |
Copilot finished work on behalf of
mawasile
June 5, 2025 11:27
mawasile
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR addresses several validation and diagnostic issues by updating error messages and improving error handling for checksum calculations and attribute validations.
- Improved diagnostic messages in validators and modifiers
- Fixed checksum error message inconsistencies (MD5 → SHA256)
- Added proper error checking when retrieving attributes
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/validators/other_field_required_when_value_of_validator.go | Enhanced error diagnostic message with clearer context. |
| internal/validators/make_field_required_when_other_field_does_not_have_value_validator.go | Updated message to clarify the issue when multiple or no matches are found. |
| internal/services/data_record/dynamic_columns_validator.go | Added error checking for attribute retrieval from config. |
| internal/modifiers/sync_attribute_plan_modifier.go | Corrected checksum error message to report SHA256 and added handling for empty checksum values. |
| internal/modifiers/set_string_value_unknown_if_checksum_change_modifier.go | Updated checksum error message and added immediate error checking for diagnostic appending. |
| internal/modifiers/set_bool_value_unknown_if_checksum_change_modifier.go | Revised error message to reflect SHA256 instead of MD5. |
| .changes/unreleased/fixed-20250605-102519.yaml | Documented the improvements and fixes in the changelog. |
internal/modifiers/set_bool_value_unknown_if_checksum_change_modifier.go
Outdated
Show resolved
Hide resolved
mawasile
added
ai assisted
…odifier.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mawasile
approved these changes
Jun 9, 2025
mattdot
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #821.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.