Fix unsafe type assertions in provider data handling

[Copilot]

This PR addresses critical type assertion safety issues in the Terraform provider that could cause runtime panics and misleading error messages.

Issues Fixed

Issue 1: Unsafe Direct Type Assertion

Several Configure functions were performing direct type assertions without safety checks:

// BEFORE - Unsafe: Could panic if req.ProviderData is not *api.ProviderClient
client := req.ProviderData.(*api.ProviderClient).Api

Issue 2: Misleading Error Messages

When type assertions failed or Api was nil, error messages incorrectly referenced *http.Client instead of the actual expected type:

// BEFORE - Misleading error message
resp.Diagnostics.AddError(
    "Unexpected Resource Configure Type",
    fmt.Sprintf("Expected *http.Client, got: %T. Please report this issue to the provider developers.", req.ProviderData),
)

Solution

Replaced all unsafe type assertions with the safe pattern used elsewhere in the codebase:

// AFTER - Safe type assertion with proper error handling
providerClient, ok := req.ProviderData.(*api.ProviderClient)
if !ok {
    resp.Diagnostics.AddError(
        "Unexpected Resource Configure Type",
        fmt.Sprintf("Expected *api.ProviderClient, got: %T. Please report this issue to the provider developers.", req.ProviderData),
    )
    return
}

For cases where additional nil checks were needed, provided clear error messages:

if client.Api == nil {
    resp.Diagnostics.AddError(
        "Nil Api client",
        "ProviderData contained a *api.ProviderClient but with nil Api. Please check provider initialization and credentials.",
    )
    return
}

Files Changed

• internal/services/environment_group_rule_set/resource_environment_group_rule_set.go
• internal/services/managed_environment/resource_managed_environment.go
• internal/services/environment_settings/resources_environment_settings.go
• internal/services/languages/datasource_languages.go
• internal/services/data_record/datasource_data_record.go
• internal/services/data_record/resource_data_record.go
• internal/services/tenant_settings/resource_tenant_settings.go

Testing

• ✅ All existing unit tests pass
• ✅ Build and lint checks pass
• ✅ Documentation generated successfully

These changes improve provider reliability by preventing potential runtime panics and providing clearer error messages for debugging configuration issues.

Fixes #841.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull Request Overview

This PR improves provider reliability by replacing unsafe direct type assertions with safe, conditional checks that prevent runtime panics and clarify error messages. Key changes include:

• Replacing unsafe type assertions with safe checks for provider data in resource configuration.
• Updating error messages to correctly indicate the expected type (*api.ProviderClient) instead of *http.Client.
• Applying these changes across multiple resource and datasource files.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
internal/services/tenant_settings/resource_tenant_settings.go	Updated safe type assertion for tenant settings with revised error messaging.
internal/services/managed_environment/resource_managed_environment.go	Introduced a nil check for the Api field before client initialization.
internal/services/languages/datasource_languages.go	Applied safe type assertion and updated error messaging in the Languages datasource.
internal/services/environment_settings/resources_environment_settings.go	Modified safe type assertion for environment settings resources.
internal/services/environment_group_rule_set/resource_environment_group_rule_set.go	Revised safe type assertion and error messaging for environment group rule sets.
internal/services/data_record/resource_data_record.go	Implemented safe type assertion in the Data Record resource configuration.
internal/services/data_record/datasource_data_record.go	Updated safe type assertion for the Data Record datasource.
.changes/unreleased/fixed-20250605-151206.yaml	Documented the fix in the unreleased changes log.