Port TS PR 59675 #1261
Open
Port TS PR 59675 #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Ports TypeScript PR 59675 by aligning JSDoc comment order in baselines and improving how comments are preserved when building nodes.
- Removed the outdated
.js.diffbaseline file - Updated
signatureOverloadsWithComments.jsto place@deprecatedand accompanying comment in the correct order - Changed
setCommentRangeinnodebuilderimpl.goto prefersignature.declarationviacore.Coalesce
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| testdata/baselines/reference/submodule/compiler/signatureOverloadsWithComments.js.diff | Deleted obsolete diff file—the baseline is now represented by the .js file |
| testdata/baselines/reference/submodule/compiler/signatureOverloadsWithComments.js | Reordered JSDoc comments to include @deprecated before comment |
| internal/checker/nodebuilderimpl.go | Use core.Coalesce(signature.declaration, …) when setting comment ranges |
Comments suppressed due to low confidence (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports https://github.com/microsoft/TypeScript/pull/59675/files