Port TS PR 61082 (Fix accidental ESM-mode directory module lookup in package non-root) #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Ports TypeScript PR #61082 to update module resolution behavior and refresh related test baselines.
- Removes an obsolete diff-based test baseline and adds a consolidated
.errors.txtfornodeModulesNoDirectoryModule. - Enhances
loadModuleFromSpecificNodeModulesDirectoryby only performing directory index lookup when there’s no subpath (rest == ""). - Retains a ported comment that questions its own correctness, which may warrant clarification.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| testdata/baselines/reference/submodule/conformance/nodeModulesNoDirectoryModule.errors.txt.diff | Removed outdated diff-based baseline |
| testdata/baselines/reference/submodule/conformance/nodeModulesNoDirectoryModule.errors.txt | Added updated, consolidated test baseline |
| internal/module/resolver.go | Added rest == "" guard in package directory resolution condition |
jakebailey
changed the title
DanielRosenwasser
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports in https://github.com/microsoft/TypeScript/pull/61082/files