-
Notifications
You must be signed in to change notification settings - Fork 663
Small fixes to fourslash tests conversion script #1393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,024
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the fourslash test conversion pipeline and associated Go test harness to align with recent changes and add new autogenerated tests.
- Adjusts the
GoToEachMarker
method signature in the Go test harness and updates existing tests accordingly. - Extends the conversion script (
convertFourslash.mts
) to handle new TS AST patterns (isStringLiteralLike
, deprecated sort text, marker initializers,isFromUncheckedFile
). - Adds a suite of new autogenerated completion tests under
internal/fourslash/tests/gen
and updates the list of failing tests.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
internal/fourslash/tests/gen/completionsWithDeprecatedTag1_test.go | Add autogenerated deprecated-tag completion test #1 |
internal/fourslash/tests/gen/completionsWithDeprecatedTag2_test.go | Add autogenerated deprecated-tag completion test #2 |
internal/fourslash/tests/gen/completionsWithDeprecatedTag4_test.go | Add autogenerated deprecated-tag completion test #4 |
internal/fourslash/tests/gen/completionsWithDeprecatedTag5_test.go | Add autogenerated deprecated-tag completion test #5 |
internal/fourslash/tests/gen/completionsWithDeprecatedTag6_test.go | Add autogenerated deprecated-tag completion test #6 |
internal/fourslash/tests/gen/completionsWithDeprecatedTag7_test.go | Add autogenerated deprecated-tag completion test #7 |
internal/fourslash/tests/gen/completionsWithDeprecatedTag9_test.go | Add autogenerated deprecated-tag completion test #9 |
internal/fourslash/tests/gen/completionsOverridingMethod10_test.go | Add autogenerated overriding-method completion test #10 |
internal/fourslash/tests/gen/completionsOverridingMethod11_test.go | Add autogenerated overriding-method completion test #11 |
internal/fourslash/tests/gen/completionsLiteralDirectlyInRestConstrainedToTupleType_test.go | Add literal-in-rest (tuple) completion test |
internal/fourslash/tests/gen/completionsLiteralDirectlyInRestConstrainedToArrayType_test.go | Add literal-in-rest (array) completion test |
internal/fourslash/tests/gen/completionsLiteralDirectlyInArgumentWithNullableConstraint_test.go | Add literal-in-argument (nullable) completion test |
internal/fourslash/tests/gen/completionsJsxExpression_test.go | Add JSX expression completion test |
internal/fourslash/tests/gen/completionsForStringDependingOnContexSensitiveSignature_test.go | Add context-sensitive string signature completion test |
internal/fourslash/tests/gen/completionsECMAPrivateMember_test.go | Add ECMA private member completion test |
internal/fourslash/tests/gen/completionNoAutoInsertQuestionDotForThis_test.go | Add no-auto-insert ?. completion test |
internal/fourslash/tests/gen/completionListAfterStringLiteral1_test.go | Add string literal member list completion test |
internal/fourslash/tests/gen/completionListAfterRegularExpressionLiteral1_test.go | Add regex literal member list completion test |
internal/fourslash/tests/gen/completionListAfterRegularExpressionLiteral01_test.go | Add regex literal (with preceding var) list completion test |
internal/fourslash/tests/gen/completionInUncheckedJSFile_test.go | Add completion in unchecked JS file test |
internal/fourslash/tests/completionListInUnclosedTypeArguments_test.go | Update GoToEachMarker invocation to new signature |
internal/fourslash/fourslash.go | Change GoToEachMarker signature to drop t *testing.T from the action callback |
internal/fourslash/_scripts/failingTests.txt | Update list of failing tests to include the newly added ones |
internal/fourslash/_scripts/convertFourslash.mts | Enhance parsing of markers, string literals, deprecated sort text, and unchecked file |
jakebailey
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.