improve resource completion order/ presentation #251922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
changed the title
meganrogge
changed the title
meganrogge
commented
Jun 19, 2025
meganrogge
commented
Jun 19, 2025
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionItem.ts
Outdated
Show resolved
Hide resolved
meganrogge
commented
Jun 19, 2025
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionModel.ts
Outdated
Show resolved
Hide resolved
meganrogge
commented
Jun 19, 2025
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionService.ts
Outdated
Show resolved
Hide resolved
Tyriar
previously requested changes
Jun 19, 2025
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionItem.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionService.ts
Outdated
Show resolved
Hide resolved
Tyriar
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #251919
fix #251924
Before:
Put punctuation methods before others.
After:
Moved those to the bottom of the methods.
Before:
.entries...and similar at the top vs bottom of the listAfter:
.method entry...and similar at the bottom of the list