Skip to content

Patch 1 #263875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 8, 2025
Merged

Patch 1 #263875

merged 5 commits into from
Jun 8, 2025

Conversation

thejjw
Copy link
Contributor

@thejjw thejjw commented Jun 8, 2025

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.10 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Resolves #263874

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-63-263875-20250608-1

@thejjw
Copy link
Contributor Author

thejjw commented Jun 8, 2025

@microsoft-github-policy-service agree

@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Jun 8, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jun 8, 2025
@thejjw
Copy link
Contributor Author

thejjw commented Jun 8, 2025

Hello @thejjw,

I am sorry to report that the Sha256 Hash does not match the installer. This may be caused by using a vanity URL rather than a URL directly to the binary.

Please check the HASH and submit again. Sorry for the inconvenience.

Template: msftbot/validationError/installers/hashMismatch

can you help me what further actions i can take? i have explicitly generated these hash from my downloads:

PS C:\Users\user\Downloads> winget hash .\WhaleSetupX64.exe
InstallerSha256: 648826d71fe5240ee71db53a9657ba8ab2719213f9c4f6729fb5bbd77e9a6e39
PS C:\Users\user\Downloads> winget hash .\WhaleSetupARM64.exe
InstallerSha256: 8e28687a09bd77293ed73726c786ccf6d6c7ab1c20b8b037f59395e3d981b774
PS C:\Users\user\Downloads> winget hash .\WhaleSetupX86.exe
InstallerSha256: 5fde77b60aa0cf31066c04164a9c8445b3300ccfca2ec2c1e3ab7ad128c03bb3
PS C:\Users\user\Downloads>

and those urls are the only url i know for the software (evergreen url i suppose)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jun 8, 2025
Copy link
Contributor

@DuckDuckStudio DuckDuckStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Architecture Expected hash Actual hash Match?
x86 5fde77b60aa0cf31066c04164a9c8445b3300ccfca2ec2c1e3ab7ad128c03bb3 5FDE77B60AA0CF31066C04164A9C8445B3300CCFCA2EC2C1E3AB7AD128C03BB3
x64 648826d71fe5240ee71db53a9657ba8ab2719213f9c4f6729fb5bbd77e9a6e39 648826D71FE5240EE71DB53A9657BA8AB2719213F9C4F6729FB5BBD77E9A6E39
arm64 648826d71fe5240ee71db53a9657ba8ab2719213f9c4f6729fb5bbd77e9a6e39 8E28687A09BD77293ED73726C786CCF6D6C7AB1C20B8B037F59395E3D981B774

i have explicitly generated these hash from my downloads.

The hash value of the files you downloaded is correct, but it seems that you fill in the hash value of the x64 installer into the arm64 installer.

@microsoft-github-policy-service microsoft-github-policy-service bot added Changes-Requested Changes Requested Needs-Author-Feedback This needs a response from the author. labels Jun 8, 2025
Co-authored-by: 鸭鸭「カモ」 <89643991+DuckDuckStudio@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-63-263875-20250608-2

@microsoft-github-policy-service microsoft-github-policy-service bot removed Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author. labels Jun 8, 2025
@thejjw
Copy link
Contributor Author

thejjw commented Jun 8, 2025

@DuckDuckStudio ah thanks fixed

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Changes-Requested Changes Requested label Jun 8, 2025
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jun 8, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) June 8, 2025 08:17
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit ae6646e into microsoft:master Jun 8, 2025
1 check passed
@stephengillie stephengillie added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jun 8, 2025
@thejjw thejjw deleted the patch-1 branch June 8, 2025 08:33
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

1 similar comment
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Dvd-Znf
Copy link
Contributor

Dvd-Znf commented Jun 8, 2025

linked issue: #263874

FYI: If you want to link a PR to an issue you need to prepend the issue id with a valid keyword in the PR's description
(Eg. Resolves #263874 instead of linked issue: #263874)

@thejjw
Copy link
Contributor Author

thejjw commented Jun 8, 2025

thanks fixed
at the time of writing i was just reacting to "Is there a linked Issue?" message more or less

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Update Request]: Naver Whale 4.32.315.11
5 participants