Skip to content

New package: Microsoft.GameInput version 1.2.26100.4782 #268681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lsalvadormsft
Copy link
Contributor

@lsalvadormsft lsalvadormsft commented Jun 26, 2025

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.10 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-65-268681-20250626-1

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-65-268681-20250626-2

@Dragon1573
Copy link
Contributor

Hi @Isalvadormsft, 👋🏼 glad to see you resolving issues by yourself.

Tip

It's recommended linking pull requests to issues via "close keywords".

Keywords are ONLY valid in your commit messages or pull request descriptions. Editing your description is required.

- [x] Is there a linked Issue? Resolve #268683

@lsalvadormsft
Copy link
Contributor Author

@stephengillie @Dragon1573 linked the PR to the issue via the Resolve issue. Are there other requirements for approval? I see a Validation-Executable-Error, but that would not appear to be specific to this PR. Thanks!

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Program Files\Microsoft GameInput\x64\GameInputRedistService.exe returned exit code: -2147023833

Hex Dec Inverted Dec Symbol Description

(Automated response - build 1078.)

@lsalvadormsft
Copy link
Contributor Author

@stephengillie this does not appear an issue with our installer, which succeeds locally. Our installer is installing a system service. Could this be not working on the pipelines?

The error that you shared appears to be an issue connecting to the service manager.

…et is called outside of an elevated terminal
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-65-268681-20250627-1

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error New-Package labels Jun 27, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jun 27, 2025
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jun 27, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jun 27, 2025
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-65-268681-20250627-2

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Jun 27, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Executable-Error Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package labels Jun 30, 2025
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jun 30, 2025
@denelon
Copy link
Collaborator

denelon commented Jul 1, 2025

@stephengillie this one is probably going to need a manual review. It's adding a system service and there isn't an executable entry point which is why I believe validation is failing.

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Program Files\Microsoft GameInput\x64\GameInputRedistService.exe returned exit code: -2147023833

Hex Dec Inverted Dec Symbol Description

(Automated response - build 1078.)

@stephengillie
Copy link
Collaborator

Verify:
image

@ stephengillie this one is probably going to need a manual review. It's adding a system service and there isn't an executable entry point which is why I believe validation is failing.

This is unexpected - the label Validation-No-Executables should have been applied in this situation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 1, 2025
@lsalvadormsft
Copy link
Contributor Author

Thanks @stephengillie and @denelon! I expect the issue is that the GameInputRedistService.exe installed can only run as SYSTEM (since it is only meant to be registered as a SYSTEM service). That screen looks great! The installer only needs elevation and does not require full SYSTEM privileges.

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-65-268681-20250701-1

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 1, 2025
@denelon denelon added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 1, 2025
@denelon denelon merged commit 7045234 into microsoft:master Jul 1, 2025
1 check passed
@lsalvadormsft
Copy link
Contributor Author

[Apologies about the accidental close/reopen. I was under the assumption that I had to complete it]

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: Microsoft.GameInput v1.2.26100.4782
6 participants