watch: add `--watch-kill-signal` flag #58719

dario-piotrowicz · 2025-06-15T18:06:18Z

add the new --watch-kill-signal to allow users to customize what signal is sent to the process on restarts during watch mode

nodejs-github-bot · 2025-06-15T18:06:23Z

Review requested:

@nodejs/config
@nodejs/test_runner

anonrig

Documentation changes are missing

dario-piotrowicz · 2025-06-15T18:19:19Z

Documentation changes are missing

Sorry my bad 🙇 , doc changes added 🙂👍

codecov · 2025-06-15T19:07:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (eaebfab) to head (ce4776c).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58719      +/-   ##
==========================================
- Coverage   90.09%   90.08%   -0.02%     
==========================================
  Files         640      640              
  Lines      188450   188452       +2     
  Branches    36966    36963       -3     
==========================================
- Hits       169789   169766      -23     
- Misses      11364    11404      +40     
+ Partials     7297     7282      -15

Files with missing lines	Coverage Δ
src/node_options.cc	`84.59% <100.00%> (+0.13%)`	⬆️
src/node_options.h	`97.87% <100.00%> (+0.01%)`	⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2025-06-28T21:03:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67711/

nodejs-github-bot · 2025-06-28T22:52:01Z

Landed in f0a9478...4d5ee24

add the new `--watch-kill-signal` to allow users to customize what signal is sent to the process on restarts during watch mode PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

add the new `--watch-kill-signal` to allow users to customize what signal is sent to the process on restarts during watch mode PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Notable changes: crypto: * (SEMVER-MINOR) support outputLength option in crypto.hash for XOF functions (Aditi) #58121 doc: * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719 fs: * (SEMVER-MINOR) add disposable mkdtempSync (Kevin Gibbons) #58516 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853 sqlite: * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697 src,permission: * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719 PR-URL: #58993

RafaelGSS · 2025-07-08T18:16:36Z

@dario-piotrowicz we should have set the stability of this API. Usually, we start with 1.1 (Active Development), but that's not mandatory.

dario-piotrowicz · 2025-07-08T18:41:27Z

@dario-piotrowicz we should have set the stability of this API. Usually, we start with 1.1 (Active Development), but that's not mandatory.

Mh... I see, yes that's a good point... although for something this small and trivial I didn't even consider that 🤔

Would you like me to open a doc PR to add the stability?

RafaelGSS · 2025-07-08T18:42:52Z

I think that would be great. I'd say to mark it as 1.1, but no need to emit a warning on usage.

dario-piotrowicz · 2025-07-08T18:48:41Z

I think that would be great. I'd say to mark it as 1.1, but no need to emit a warning on usage.

#58997 🙂

Notable changes: crypto: * (SEMVER-MINOR) support outputLength option in crypto.hash for XOF functions (Aditi) #58121 doc: * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719 fs: * (SEMVER-MINOR) add disposable mkdtempSync (Kevin Gibbons) #58516 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853 sqlite: * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697 src,permission: * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719 PR-URL: #58993

add the new `--watch-kill-signal` to allow users to customize what signal is sent to the process on restarts during watch mode PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

add the new `--watch-kill-signal` to allow users to customize what signal is sent to the process on restarts during watch mode PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Notable changes: deps: * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350 * (SEMVER-MINOR) update amaro to 1.0.0 (Node.js GitHub Bot) #56350 * (SEMVER-MINOR) update amaro to 0.5.3 (Node.js GitHub Bot) #56350 * (SEMVER-MINOR) update amaro to 0.5.2 (Node.js GitHub Bot) #56350 * (SEMVER-MINOR) update amaro to 0.5.1 (Marco Ippolito) #56350 * (SEMVER-MINOR) update amaro to 0.5.0 (nodejs-github-bot) #56350 doc: * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719 * add islandryu to collaborators (Shima Ryuhei) #58714 * (SEMVER-MINOR) add history entries to `--input-type` section (Antoine du Hamel) #56350 esm: * (SEMVER-MINOR) implement import.meta.main (Joe) #57804 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490 module: * (SEMVER-MINOR) improve typescript error message format (Marco Ippolito) #56350 * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350 * (SEMVER-MINOR) refactor commonjs typescript loader (Marco Ippolito) #56350 * (SEMVER-MINOR) unflag --experimental-strip-types (Marco Ippolito) #56350 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853 sqlite: * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697 src,permission: * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951 test: * (SEMVER-MINOR) add test for async disposable worker thread (James M Snell) #58385 url: * (SEMVER-MINOR) add fileURLToPathBuffer API (James M Snell) #58700 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719 worker: * (SEMVER-MINOR) make Worker async disposable (James M Snell) #58385 PR-URL: #59256

Notable changes: deps: * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350 doc: * add islandryu to collaborators (Shima Ryuhei) #58714 esm: * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490 module: * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350 * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853 sqlite: * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697 src,permission: * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951 url: * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719 worker: * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385 PR-URL: #59256 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot added c++ lib / src needs-ci labels Jun 15, 2025

dario-piotrowicz added semver-minor needs-ci lib / src and removed c++ lib / src needs-ci labels Jun 15, 2025

dario-piotrowicz force-pushed the dario/watch-mode-kill-signal branch from 1d23a46 to 96426c5 Compare June 15, 2025 18:09

anonrig reviewed Jun 15, 2025

View reviewed changes

dario-piotrowicz force-pushed the dario/watch-mode-kill-signal branch from 96426c5 to 83894cf Compare June 15, 2025 18:18

dario-piotrowicz force-pushed the dario/watch-mode-kill-signal branch 2 times, most recently from 887d4b7 to f90f6be Compare June 15, 2025 20:31

anonrig approved these changes Jun 15, 2025

View reviewed changes

anonrig added author ready request-ci labels Jun 15, 2025

github-actions bot removed the request-ci label Jun 15, 2025

This comment was marked as outdated.

Sign in to view

dario-piotrowicz force-pushed the dario/watch-mode-kill-signal branch from f90f6be to 973b29c Compare June 17, 2025 21:38

This comment was marked as outdated.

Sign in to view

dario-piotrowicz force-pushed the dario/watch-mode-kill-signal branch from 973b29c to 3b17c10 Compare June 17, 2025 22:55

This comment was marked as outdated.

Sign in to view

dario-piotrowicz force-pushed the dario/watch-mode-kill-signal branch from 3b17c10 to 229863f Compare June 18, 2025 00:01

This comment was marked as outdated.

Sign in to view

dario-piotrowicz added the commit-queue-rebase label Jun 28, 2025

anonrig approved these changes Jun 28, 2025

View reviewed changes

dario-piotrowicz added the request-ci label Jun 28, 2025

github-actions bot removed the request-ci label Jun 28, 2025

dario-piotrowicz added the commit-queue label Jun 28, 2025

nodejs-github-bot removed the commit-queue label Jun 28, 2025

nodejs-github-bot pushed a commit that referenced this pull request Jun 28, 2025

doc: add all watch-mode related flags to node.1

4d5ee24

PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs-github-bot closed this Jun 28, 2025

dario-piotrowicz deleted the dario/watch-mode-kill-signal branch June 29, 2025 00:57

targos pushed a commit that referenced this pull request Jul 3, 2025

doc: add all watch-mode related flags to node.1

80dec98

PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

github-actions bot mentioned this pull request Jul 8, 2025

2025-07-09, Version 24.4.0 (Current) #58993

Merged

dario-piotrowicz mentioned this pull request Jul 8, 2025

doc: add stability index to the --watch-kill-signal flag #58997

Merged

ASAav123 mentioned this pull request Jul 9, 2025

Review requested: #59009

Closed

2 tasks

aduh95 pushed a commit that referenced this pull request Jul 21, 2025

doc: add all watch-mode related flags to node.1

3228382

PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

aduh95 pushed a commit that referenced this pull request Jul 24, 2025

doc: add all watch-mode related flags to node.1

d80ef2a

PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

github-actions bot mentioned this pull request Jul 28, 2025

2025-07-29, Version 22.18.0 'Jod' (LTS) #59256

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

watch: add `--watch-kill-signal` flag #58719

watch: add `--watch-kill-signal` flag #58719

dario-piotrowicz commented Jun 15, 2025

Uh oh!

nodejs-github-bot commented Jun 15, 2025

Uh oh!

anonrig left a comment

Uh oh!

dario-piotrowicz commented Jun 15, 2025

Uh oh!

codecov bot commented Jun 15, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Jun 28, 2025

Uh oh!

nodejs-github-bot commented Jun 28, 2025

Uh oh!

RafaelGSS commented Jul 8, 2025

Uh oh!

dario-piotrowicz commented Jul 8, 2025

Uh oh!

RafaelGSS commented Jul 8, 2025

Uh oh!

dario-piotrowicz commented Jul 8, 2025

Uh oh!

Uh oh!

Uh oh!

watch: add --watch-kill-signal flag #58719

watch: add --watch-kill-signal flag #58719

Conversation

dario-piotrowicz commented Jun 15, 2025

Uh oh!

nodejs-github-bot commented Jun 15, 2025

Uh oh!

anonrig left a comment

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz commented Jun 15, 2025

Uh oh!

codecov bot commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Jun 28, 2025

Uh oh!

nodejs-github-bot commented Jun 28, 2025

Uh oh!

RafaelGSS commented Jul 8, 2025

Uh oh!

dario-piotrowicz commented Jul 8, 2025

Uh oh!

RafaelGSS commented Jul 8, 2025

Uh oh!

dario-piotrowicz commented Jul 8, 2025

Uh oh!

Uh oh!

watch: add `--watch-kill-signal` flag #58719

watch: add `--watch-kill-signal` flag #58719

codecov bot commented Jun 15, 2025 •

edited

Loading