-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
watch: add --watch-kill-signal
flag
#58719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watch: add --watch-kill-signal
flag
#58719
Conversation
Review requested:
|
1d23a46
to
96426c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation changes are missing
96426c5
to
83894cf
Compare
Sorry my bad 🙇 , doc changes added 🙂👍 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58719 +/- ##
==========================================
- Coverage 90.09% 90.08% -0.02%
==========================================
Files 640 640
Lines 188450 188452 +2
Branches 36966 36963 -3
==========================================
- Hits 169789 169766 -23
- Misses 11364 11404 +40
+ Partials 7297 7282 -15
🚀 New features to boost your workflow:
|
887d4b7
to
f90f6be
Compare
This comment was marked as outdated.
This comment was marked as outdated.
f90f6be
to
973b29c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
973b29c
to
3b17c10
Compare
This comment was marked as outdated.
This comment was marked as outdated.
3b17c10
to
229863f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi @atlowChemi, thanks a lot for having a look 🫶 I think you're right, but could you clarify why this needs to be added to node.1? (sorry I am simply not familiar with that file) Also I don't see any of the watch related flags in that file.... so it feels a bit weird to add this one.... maybe the right thing would be to keep this PR as is and then add all the watch related flags to that file as a followup? (but again I would love to understand what the file does first 😅) |
add the new `--watch-kill-signal` to allow users to customize what signal is sent to the process on restarts during watch mode
229863f
to
ce4776c
Compare
Alright @atlowChemi , node.1 is for the man page... sorry for not knowing 🙈😓 I've added |
Landed in f0a9478...4d5ee24 |
add the new `--watch-kill-signal` to allow users to customize what signal is sent to the process on restarts during watch mode PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
add the new `--watch-kill-signal` to allow users to customize what signal is sent to the process on restarts during watch mode PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Notable changes: crypto: * (SEMVER-MINOR) support outputLength option in crypto.hash for XOF functions (Aditi) #58121 doc: * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719 fs: * (SEMVER-MINOR) add disposable mkdtempSync (Kevin Gibbons) #58516 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853 sqlite: * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697 src,permission: * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719 PR-URL: #58993
@dario-piotrowicz we should have set the stability of this API. Usually, we start with 1.1 (Active Development), but that's not mandatory. |
Mh... I see, yes that's a good point... although for something this small and trivial I didn't even consider that 🤔 Would you like me to open a doc PR to add the stability? |
I think that would be great. I'd say to mark it as 1.1, but no need to emit a warning on usage. |
#58997 🙂 |
Notable changes: crypto: * (SEMVER-MINOR) support outputLength option in crypto.hash for XOF functions (Aditi) #58121 doc: * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719 fs: * (SEMVER-MINOR) add disposable mkdtempSync (Kevin Gibbons) #58516 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853 sqlite: * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697 src,permission: * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719 PR-URL: #58993
add the new
--watch-kill-signal
to allow users to customize what signal is sent to the process on restarts during watch mode