watch: add --watch-kill-signal flag
#58719
Closed
+160
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
dario-piotrowicz
added
semver-minor
dario-piotrowicz
force-pushed
the
dario/watch-mode-kill-signal
branch
from
1d23a46 to
96426c5
Compare
anonrig
reviewed
Jun 15, 2025
dario-piotrowicz
force-pushed
the
dario/watch-mode-kill-signal
branch
from
96426c5 to
83894cf
Compare
Sorry my bad 🙇 , doc changes added 🙂👍 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58719 +/- ##
==========================================
- Coverage 90.09% 90.08% -0.02%
==========================================
Files 640 640
Lines 188450 188452 +2
Branches 36966 36963 -3
==========================================
- Hits 169789 169766 -23
- Misses 11364 11404 +40
+ Partials 7297 7282 -15
🚀 New features to boost your workflow:
|
dario-piotrowicz
force-pushed
the
dario/watch-mode-kill-signal
branch
2 times, most recently
from
887d4b7 to
f90f6be
Compare
anonrig
approved these changes
Jun 15, 2025
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
dario-piotrowicz
force-pushed
the
dario/watch-mode-kill-signal
branch
from
f90f6be to
973b29c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
dario-piotrowicz
force-pushed
the
dario/watch-mode-kill-signal
branch
from
973b29c to
3b17c10
Compare
This comment was marked as outdated.
This comment was marked as outdated.
dario-piotrowicz
force-pushed
the
dario/watch-mode-kill-signal
branch
from
3b17c10 to
229863f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi @atlowChemi, thanks a lot for having a look 🫶 I think you're right, but could you clarify why this needs to be added to node.1? (sorry I am simply not familiar with that file) Also I don't see any of the watch related flags in that file.... so it feels a bit weird to add this one.... maybe the right thing would be to keep this PR as is and then add all the watch related flags to that file as a followup? (but again I would love to understand what the file does first 😅) |
add the new `--watch-kill-signal` to allow users to customize what signal is sent to the process on restarts during watch mode
dario-piotrowicz
force-pushed
the
dario/watch-mode-kill-signal
branch
from
229863f to
ce4776c
Compare
|
Alright @atlowChemi , node.1 is for the man page... sorry for not knowing 🙈😓 I've added |
dario-piotrowicz
added
the
commit-queue-rebase
anonrig
approved these changes
Jun 28, 2025
dario-piotrowicz
added
the
request-ci
github-actions
bot
removed
the
request-ci
dario-piotrowicz
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f0a9478...4d5ee24 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 28, 2025
add the new `--watch-kill-signal` to allow users to customize what signal is sent to the process on restarts during watch mode PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 28, 2025
PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
that referenced
this pull request
Jul 3, 2025
add the new `--watch-kill-signal` to allow users to customize what signal is sent to the process on restarts during watch mode PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
that referenced
this pull request
Jul 3, 2025
PR-URL: #58719 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
nodejs-github-bot
added a commit
that referenced
this pull request
Jul 8, 2025
Notable changes: crypto: * (SEMVER-MINOR) support outputLength option in crypto.hash for XOF functions (Aditi) #58121 doc: * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719 fs: * (SEMVER-MINOR) add disposable mkdtempSync (Kevin Gibbons) #58516 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853 sqlite: * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697 src,permission: * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719 PR-URL: #58993
|
@dario-piotrowicz we should have set the stability of this API. Usually, we start with 1.1 (Active Development), but that's not mandatory. |
Mh... I see, yes that's a good point... although for something this small and trivial I didn't even consider that 🤔 Would you like me to open a doc PR to add the stability? |
|
I think that would be great. I'd say to mark it as 1.1, but no need to emit a warning on usage. |
#58997 🙂 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 9, 2025
Notable changes: crypto: * (SEMVER-MINOR) support outputLength option in crypto.hash for XOF functions (Aditi) #58121 doc: * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719 fs: * (SEMVER-MINOR) add disposable mkdtempSync (Kevin Gibbons) #58516 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853 sqlite: * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697 src,permission: * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719 PR-URL: #58993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the new
--watch-kill-signalto allow users to customize what signal is sent to the process on restarts during watch mode