You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposal to allow us to leverage signals without the need for the Preact Hooks implementation, this should save about 1.2kb gzipped as we aren't pulling in all of the other hooks. The main thing that people might miss are useMemo/useCallback - in theory we could use useComputed for that with .value however now sure we want to encourage that.
We could export a version of useStoreValue for this?
Additionally, useRef is replaced with useSignalRef.
In the ecosystem we'll nee to add support for this in prefresh, which comes down to adding the new property in here
For consumers who leverage both signals and hooks this is a slight downgrade, however, the added bytes are minimal in signals so I would encourage catering to users who use one of both rather than both.
Thinking more about this, a lot of our ecosystem libraries like i.e. preact-iso do leverage signals so in that regards this would be just an addition in byte-size. Gotta think this through a bit more.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Thinking more about this, a lot of our ecosystem libraries like i.e. preact-iso do leverage signals so in that regards this would be just an addition in byte-size.
I imagine you mean "...do leverage hooks..." (emphasis mine), but indeed.
I originally gave the feature request a thumbs up, but now that you've laid this out, I'm thinking you're right, this would just be a regression for most users. I suppose unbundled apps might get to drop an additional network request for preact/hooks but neither that nor -1.2kb is super interesting. Equally though, a slight increase in size shouldn't cause anyone problems either.
Biggest selling point might just be the purity of the implementation but even that's pretty moot.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JoviDeCroock
force-pushed
the
avoid-hooks-usage
branch
from
Resolves #670
This is a proposal to allow us to leverage signals without the need for the Preact Hooks implementation, this should save about 1.2kb gzipped as we aren't pulling in all of the other hooks. The main thing that people might miss are
useMemo/useCallback- in theory we could useuseComputedfor that with.valuehowever now sure we want to encourage that.We could export a version of
useStoreValuefor this?Additionally,
useRefis replaced withuseSignalRef.In the ecosystem we'll nee to add support for this in
prefresh, which comes down to adding the new property in hereFor consumers who leverage both signals and hooks this is a slight downgrade, however, the added bytes are minimal in signals so I would encourage catering to users who use one of both rather than both.
Thinking more about this, a lot of our ecosystem libraries like i.e. preact-iso do leverage signals so in that regards this would be just an addition in byte-size. Gotta think this through a bit more.