-
Notifications
You must be signed in to change notification settings - Fork 11
Support include and exclude for property groups #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support include and exclude for property groups #660
Conversation
docs/api/thermostats/README.md
Outdated
--- | ||
|
||
|
||
## Errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DebbieAtSeam Didn't realize this until now, but we will need to be able to group the errors and warnings.
@@ -1,5 +1,867 @@ | |||
# Thermostats | |||
|
|||
## The device Object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@razor-x How do we get this to say "The thermostat Object" instead of the "The device Object"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no thermostat object. This is a device
resource. Should we say something else here that is more accurate, e.g., that these are the relevant properties of device
for using the /thermostats
API? Let's decide on the language first and we can adjust the template. We will likely need to incorporate this into the path metadata.
@DebbieAtSeam This one should be good to go now. We can keep adjusting the groups as needed but the codegen logic here should be correct now. The larger diff is because a sorted the groups and variants. Side note, for sorting stuff, if needed we could introduce some kind of priority annotation, but I think this is a later problem to solve. |
Renders device properties for the thermostat group on
/thermostats
.