-
-
Notifications
You must be signed in to change notification settings - Fork 843
feat: add blas/ext/index-of
#7565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
lib/node_modules/@stdlib/blas/ext/index-of/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
…dlib into top-blas-indexof
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
} else { | ||
throw new TypeError( format( 'invalid argument. Third argument must be either an ndarray or an integer. Value: `%s`.', fromIndex ) ); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing out
argument validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here also, notice the case assign( x, searchElement, out, options )
at L132, and also the case above assign( x, searchElement, out )
. Since fromIndex
is optional and can be at 3rd place, the issue is that fromIndex
can also be ndarrayLike
so consider the case assign( x, searchElement, fromIndex_ndarray )
. How would we know if that ndarray is a fromIndex
or out
?
Based on that, I think, the check for out
makes sense just before the call to base
.
Also, as suggested by you, I tried to comeup with ndarrayLike
checks at the top but that also is tricky because we need to first check if fromIndex
is actually that or is it out
& vice versa. So at the end, we will end up with same amount of ndarraylike
checks as we have now.
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Progresses #2656.
Description
This pull request:
blas/ext/index-of
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers