Skip to content

Fix PHP 8.5 #5817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix PHP 8.5 #5817

wants to merge 7 commits into from

Conversation

naizhao
Copy link

@naizhao naizhao commented Jul 6, 2025

Fixed Swoole compilation errors under PHP 8.5 and added the missing third-party directory

@NathanFreeman
Copy link
Member

谢谢你的贡献,还缺少一些要修改的。
config.m4需要添加上这些新增的文件。
swoole_pgsql.cc,swoole_oracle.cc,swoole_odbc.cc和swoole_sqlite.cc需要根据不同的PHP版本,引入不同的头文件

@thecaliskan
Copy link

Hi @naizhao

Thanks for the contributing. Could you add 8.5 to the GitHub Actions workflows ?

@naizhao
Copy link
Author

naizhao commented Jul 7, 2025

Hi @naizhao

Thanks for the contributing. Could you add 8.5 to the GitHub Actions workflows ?

PHP 8.5 hasn't been officially released yet; it's currently in alpha1. I reviewed the GitHub Actions code and found that it heavily relies on methods like apt to install PHP's compilation dependency modules. Since apt doesn't currently have PHP 8.5 available, GitHub Actions is generating numerous errors. This would require refactoring the compilation process to build everything from PHP source code instead.
image

@naizhao
Copy link
Author

naizhao commented Jul 7, 2025

Also, some tests depend on your Docker images, and the Swoole PHP 8.5 Docker image is missing too

@thecaliskan
Copy link

thecaliskan commented Jul 7, 2025

shivammathur/setup-php seems to have PHP 8.5 but there might be a problem with some other packages.

php-version: [ '8.1', '8.2', '8.3', '8.4' ]

https://github.com/shivammathur/setup-php#tada-php-support

image
image

@thecaliskan
Copy link

You can add it as fail safe for workflows that currently support it.

continue-on-error: ${{ matrix.php-version == '8.5' }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants