-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix PHP 8.5 #5817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix PHP 8.5 #5817
Conversation
In PHP 8.5, the `shutdown_function_entry` has been modified.
谢谢你的贡献,还缺少一些要修改的。 |
Hi @naizhao Thanks for the contributing. Could you add 8.5 to the GitHub Actions workflows ? |
PHP 8.5 hasn't been officially released yet; it's currently in alpha1. I reviewed the GitHub Actions code and found that it heavily relies on methods like |
Also, some tests depend on your Docker images, and the Swoole PHP 8.5 Docker image is missing too |
shivammathur/setup-php seems to have PHP 8.5 but there might be a problem with some other packages.
|
You can add it as fail safe for workflows that currently support it.
|
Fixed Swoole compilation errors under PHP 8.5 and added the missing third-party directory