-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Refine Dockerhub Detector for Improved Accuracy & Coverage #4219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
shahzadhaider1
wants to merge
11
commits into
trufflesecurity:main
Choose a base branch
from
shahzadhaider1:feat/OSS-179-dockerhub-improve
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refine Dockerhub Detector for Improved Accuracy & Coverage #4219
shahzadhaider1
wants to merge
11
commits into
trufflesecurity:main
from
shahzadhaider1:feat/OSS-179-dockerhub-improve
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc38662
to
91b5e3d
Compare
7283d81
to
d26f579
Compare
if err != nil { | ||
return false, nil, err | ||
// Helper function to detect if a string looks like a UUID fragment | ||
func isLikelyUUIDFragment(s string) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use github.com/google/uuid
to parse the string and verify whether it's a valid UUID?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR streamlines the Dockerhub detector to improve both its precision and recall for identifying Dockerhub Personal Access Tokens (PATs) and usernames.
Key updates include:
usernamePat
now correctly accounts for usernames starting with alphanumeric characters and allows for underscores and hyphens within the username, matching actual Dockerhub ID formats. It also refines whitespace handling for cleaner matches.accessTokenPat
is significantly enhanced. It now explicitly matches a broader set of common keywords (e.g.,docker pat
,access token
) and gracefully handles various key-value pair delimiters (colons, equals signs, quotes), ensuring tokens are found across diverse configurations.excludeHeaderPat
specifically filters out UUIDs found in benign Docker HTTP headers (e.g.,X-Docker-Upload-UUID
), preventing them from being flagged as secrets.These changes make the detector more effective by closely aligning it with real-world Docker credential patterns, leading to more accurate and relevant findings.
Checklist:
make test-community
)?make lint
this requires golangci-lint)?