wip: effect sql kysely new proposal #5156
Draft
+148
−210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
This proposal (or suggestion of a proposal) is there to make working with Kysely less prone to errors, due to the current way of patching and proxying Kysely objects. There may be better approaches, in the meanwhile, I wanted to open this PR to start discussing them.
The idea is to build a couple of wrappers while omitting some Kysely builtin methods that would otherwise let the user exit from the Effect world.
Also, this is mainly due to this error occurring: https://discord.com/channels/795981131316985866/1134177528098078861/1389230820790763571
Note: the SqlClient implementation is missing, as well as transaction handling, as I am not that much into how the effect-sql packages should work right now.
Related