Skip to content

wip: effect sql kysely new proposal #5156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kristiannotari
Copy link

@kristiannotari kristiannotari commented Jul 3, 2025

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This proposal (or suggestion of a proposal) is there to make working with Kysely less prone to errors, due to the current way of patching and proxying Kysely objects. There may be better approaches, in the meanwhile, I wanted to open this PR to start discussing them.

The idea is to build a couple of wrappers while omitting some Kysely builtin methods that would otherwise let the user exit from the Effect world.

Also, this is mainly due to this error occurring: https://discord.com/channels/795981131316985866/1134177528098078861/1389230820790763571

Note: the SqlClient implementation is missing, as well as transaction handling, as I am not that much into how the effect-sql packages should work right now.

Related

  • Related Issue #
  • Closes #

@github-project-automation github-project-automation bot moved this to Discussion Ongoing in PR Backlog Jul 3, 2025
Copy link

changeset-bot bot commented Jul 3, 2025

⚠️ No Changeset found

Latest commit: c1684d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Discussion Ongoing
Development

Successfully merging this pull request may close these issues.

1 participant