CSProgram: renderer user input state #2584
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +26 B (+0.01%) Total Size: 473 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (df5f178) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2584If you are working in Khan Academy's frontend, you can run the below command. ./tools/bump_perseus_version.js -t PR2584If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -s n -t PR2584 |
SonicScrewdriver
approved these changes
Jun 18, 2025
| @@ -8,7 +8,6 @@ import * as React from "react"; | |||
| import _ from "underscore"; | |||
|
|
|||
| import {getDependencies} from "../../dependencies"; | |||
| import * as Changeable from "../../mixins/changeable"; | |||
There was a problem hiding this comment.
YES THANK YOU. Little by little, we're finally getting rid of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See the parent PR for more context. Part of LEMS-3208.
In #2566 I add additional APIs to let widgets consume
userInputfrom a parent and to update that parent state usinghandleUserInput, while also supporting the legacy way of storing user input (which was a combination of internal widget state and stashing state in a random blob in Renderer). This PR is part of a series of PRs that go widget-by-widget to use the new API.This is a generic summary I'm putting on each PR and not every point will be applicable to every widget, but the common themes are:
getSerializedStateandgetUserInputFromSerializedStateto keep supporting the expected results.userInputstate in Renderer. This means consuminguserInputin the component and callinghandleUserInputon change.transformdid something to initialize user input state, I moved the logic togetStartUserInput.staticTransformdid something to get correct state in static widgets, I moved the logic togetCorrectUserInput.Please see the parent PR for more information.
CSProgramEditor doesn't use CSProgram, so this shouldn't affect the editing experience