WIP - Remove renderer's deprecated getUserInput in favor of the preferred getUserInputMap #2590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UserInputMap Also removes a test that was testing the deprecated functionality
…ecated array version of user input with preferred object version
|
Size Change: -49 B (-0.01%) Total Size: 472 kB
ℹ️ View Unchanged
|
Myranae
changed the title
Myranae
commented
Jun 12, 2025
Comment on lines
+2
to
+5
| "@khanacademy/perseus": major | ||
| --- | ||
|
|
||
| Replace deprecated array format of user input with preferred object format to consolidate the user input types. |
There was a problem hiding this comment.
I am pretty sure this is a major change, but not sure if I need to add more information to the changelog. I add more details in the PR summary, so not sure.
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (21cbbdb) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2590If you are working in Khan Academy's frontend, you can run the below command. ./tools/bump_perseus_version.js -t PR2590If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -s n -t PR2590 |
Myranae
force-pushed
the
tb/LEMS-2523/merge-get-user-input-map
branch
from
a45d3b8 to
68a6c2d
Compare
…ngly unneeded code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Renderer currently has two methods for getting user input: the deprecated method getUserInput which returns an array of type UserInputArray and the preferred getUserInputMap which returns an object of type UserInputMap. The object type is the preferred format going forward and is currently used in scoring and will be used in scoring via the new Perseus service.
To remove the deprecated method, we replace all uses of it in Perseus with the preferred method and then delete tests and comments related to the deprecated method. This change will require some coordination with other teams that rely on this functionality outside of Perseus and most likely updates to where user input is consumed. Testing will take place to determine the necessary places that require updates.
Issue: LEMS-2523
Test plan:
--- Use the tests to update all usages until all tests pass