-
Notifications
You must be signed in to change notification settings - Fork 357
Convert Aphrodite to CSS Modules in scrollable-view component #2613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Aphrodite to CSS Modules in scrollable-view component #2613
Conversation
…: Convert Aphrodite to CSS Modules in scrollable-view component
…te styling to CSS Modules.
Size Change: -30 B (-0.01%) Total Size: 473 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (de1e4f3) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2613 If you are working in Khan Academy's frontend, you can run the below command. ./tools/bump_perseus_version.ts -t PR2613 If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR2613 |
…s with new classname info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks GREAT! Thank you for cleaning this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
/> | ||
)} | ||
<div | ||
{...additionalProps} | ||
role={role} | ||
className={className} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking my understanding: Are you adding this className
prop so people can override the styles later if needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Override or add to.
…ain' into LEMS-3184-remove-style-objects-from-scrollable-view
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus-core@16.1.0 ### Minor Changes - [#2663](#2663) [`d1299f6f7`](d1299f6) Thanks [@benchristel](https://github.com/benchristel)! - Enable `parseAndMigratePerseusItem` to parse answerless data, i.e. the return value of `splitPerseusItem`. ### Patch Changes - [#2649](#2649) [`01cb73bef`](01cb73b) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph][locked figures] Add `weight` option to locked polygon and locked polygon settings ## @khanacademy/keypad-context@3.0.22 ### Patch Changes - Updated dependencies \[[`d1299f6f7`](d1299f6), [`01cb73bef`](01cb73b)]: - @khanacademy/perseus-core@16.1.0 ## @khanacademy/kmath@2.0.22 ### Patch Changes - Updated dependencies \[[`d1299f6f7`](d1299f6), [`01cb73bef`](01cb73b)]: - @khanacademy/perseus-core@16.1.0 ## @khanacademy/math-input@26.0.11 ### Patch Changes - Updated dependencies \[[`d1299f6f7`](d1299f6), [`01cb73bef`](01cb73b)]: - @khanacademy/perseus-core@16.1.0 - @khanacademy/keypad-context@3.0.22 ## @khanacademy/perseus@65.3.7 ### Patch Changes - [#2663](#2663) [`d1299f6f7`](d1299f6) Thanks [@benchristel](https://github.com/benchristel)! - Enable `parseAndMigratePerseusItem` to parse answerless data, i.e. the return value of `splitPerseusItem`. - [#2649](#2649) [`01cb73bef`](01cb73b) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph][locked figures] Add `weight` option to locked polygon and locked polygon settings - [#2613](#2613) [`d02d6f9fe`](d02d6f9) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Convert Aphrodite to CSS Modules in scrollable-view component - Updated dependencies \[[`d1299f6f7`](d1299f6), [`01cb73bef`](01cb73b)]: - @khanacademy/perseus-core@16.1.0 - @khanacademy/keypad-context@3.0.22 - @khanacademy/kmath@2.0.22 - @khanacademy/math-input@26.0.11 - @khanacademy/perseus-linter@4.0.9 - @khanacademy/perseus-score@7.1.9 ## @khanacademy/perseus-editor@25.1.1 ### Patch Changes - [#2649](#2649) [`01cb73bef`](01cb73b) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph][locked figures] Add `weight` option to locked polygon and locked polygon settings - Updated dependencies \[[`d1299f6f7`](d1299f6), [`01cb73bef`](01cb73b), [`d02d6f9fe`](d02d6f9)]: - @khanacademy/perseus-core@16.1.0 - @khanacademy/perseus@65.3.7 - @khanacademy/keypad-context@3.0.22 - @khanacademy/kmath@2.0.22 - @khanacademy/math-input@26.0.11 - @khanacademy/perseus-linter@4.0.9 - @khanacademy/perseus-score@7.1.9 ## @khanacademy/perseus-linter@4.0.9 ### Patch Changes - Updated dependencies \[[`d1299f6f7`](d1299f6), [`01cb73bef`](01cb73b)]: - @khanacademy/perseus-core@16.1.0 ## @khanacademy/perseus-score@7.1.9 ### Patch Changes - Updated dependencies \[[`d1299f6f7`](d1299f6), [`01cb73bef`](01cb73b)]: - @khanacademy/perseus-core@16.1.0 - @khanacademy/kmath@2.0.22 ## @khanacademy/perseus-dev-ui@5.5.6 ### Patch Changes - Updated dependencies \[[`d1299f6f7`](d1299f6), [`01cb73bef`](01cb73b)]: - @khanacademy/perseus-core@16.1.0 - @khanacademy/kmath@2.0.22 - @khanacademy/math-input@26.0.11 - @khanacademy/perseus-linter@4.0.9
Summary:
Simple move of styling into a separate CSS file.
Issue: LEMS-3184
Test plan: