Wonder Blocks: Remove deprecated semanticColor.text and semanticColor.border token instances #2627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 19, 2025 15:40
…er with sc.border equivalents
…olor.core` WB tokens instead of the now deprecated sc.text and sc.border tokens
|
Size Change: +21 B (0%) Total Size: 472 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (ec8dcd2) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2627If you are working in Khan Academy's frontend, you can run the below command. ./tools/bump_perseus_version.js -t PR2627If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -s n -t PR2627 |
jeremywiebe
approved these changes
Jun 21, 2025
There was a problem hiding this comment.
I pushed one commit to utils/extract-css.js (a tool that Mark is building to extract aphrodite styles to CSS modules), just to keep things current. Can you double-check I mapped them correctly?
I don't see any other instances of the deprecated semanticColor symbols now.
jandrade
commented
Jun 24, 2025
Comment on lines
+32
to
+35
| "#21242c": "--wb-semanticColor-core-foreground-neutral-strong", | ||
| "#5f6167": "--wb-semanticColor-core-foreground-neutral-default", | ||
| "#b8b9bb": "--wb-semanticColor-core-foreground-disabled-default", | ||
| "#ffffff": "--wb-semanticColor-core-foreground-inverse-strong", |
Merged
handeyeco
pushed a commit
that referenced
this pull request
Jun 24, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@65.3.4 ### Patch Changes - [#2627](#2627) [`4788af376`](4788af3) Thanks [@jandrade](https://github.com/jandrade)! - Updates styles to use `semanticColor.core` WB tokens instead of the now deprecated sc.text and sc.border tokens ## @khanacademy/perseus-editor@25.0.4 ### Patch Changes - [#2627](#2627) [`4788af376`](4788af3) Thanks [@jandrade](https://github.com/jandrade)! - Updates styles to use `semanticColor.core` WB tokens instead of the now deprecated sc.text and sc.border tokens - Updated dependencies \[[`4788af376`](4788af3)]: - @khanacademy/perseus@65.3.4 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updates styles to use
semanticColor.coreWB tokens instead of the nowdeprecated sc.text and sc.border tokens, which were previously used
for text and border colors.
This change is part of the ongoing effort to standardize our new
coresemanticcolor tokens across repositories, so that we can have a consistent approach
with Design specs.
Docs: https://khan.github.io/wonder-blocks/?path=/docs/foundations-using-color--docs#core
Issue: "none"
Test plan:
Verify that the following components render without any visual changes: