-
Notifications
You must be signed in to change notification settings - Fork 357
Remove long-outdated "star property hack" #2628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Size Change: 0 B Total Size: 472 kB ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (4817675) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR2628 If you are working in Khan Academy's frontend, you can run the below command. ./tools/bump_perseus_version.js -t PR2628 If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -s n -t PR2628 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Removes the outdated IE7-specific “star property hack” (*zoom: 1
) from two style sheets, since modern browsers no longer require it.
- Delete legacy clearfix rule in
radio.css
- Delete the same legacy clearfix rule in
util.css
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/perseus/src/styles/widgets/radio.css | Remove *zoom: 1 rule from the clearfix block |
packages/perseus/src/styles/util.css | Remove *zoom: 1 rule from the clearfix block |
Comments suppressed due to low confidence (2)
packages/perseus/src/styles/widgets/radio.css:11
- [nitpick] The
.perseus-clearfix
definition appears in multiple CSS files. Consider centralizing the clearfix rules into a shared utility stylesheet to avoid duplication and ease future updates.
}
packages/perseus/src/styles/widgets/radio.css:11
- Since this removes a layout-related hack, adding a visual regression test for the affected components (e.g., radio widget containers) can help catch any unintended layout shifts.
}
… longer supported)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyrum's Law at its finest 🙈. LGTM.
Summary:
This PR removes an old CSS hack that are no longer relevant in our codebase (it's for IE7!)
Specifically, I noticed the CSS compiler balking at:
*zoom: 1
. So I asked the Genie about it and here's the explanation it gave.Issue:
Test plan:
I don't think this is a risky change as it's documented as being ignored by modern browsers and specifically for IE7!