Skip to content

Add tabIndex as a prop to PhosphorIcon #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kevinb-khan
Copy link
Contributor

Summary:

PhosphorIcon already support the tabIndex prop, this change updates the types to reflect that.

Issue: XXX-XXXX

Test plan:

  • run unit tests for PhosphorIcon

@kevinb-khan kevinb-khan self-assigned this Apr 29, 2025
Copy link

changeset-bot bot commented Apr 29, 2025

🦋 Changeset detected

Latest commit: 42821e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@khanacademy/wonder-blocks-icon Patch
@khanacademy/wonder-blocks-accordion Patch
@khanacademy/wonder-blocks-banner Patch
@khanacademy/wonder-blocks-birthday-picker Patch
@khanacademy/wonder-blocks-button Patch
@khanacademy/wonder-blocks-dropdown Patch
@khanacademy/wonder-blocks-form Patch
@khanacademy/wonder-blocks-icon-button Patch
@khanacademy/wonder-blocks-link Patch
@khanacademy/wonder-blocks-search-field Patch
@khanacademy/wonder-blocks-switch Patch
@khanacademy/wonder-blocks-modal Patch
@khanacademy/wonder-blocks-popover Patch
@khanacademy/wonder-blocks-pill Patch
@khanacademy/wonder-blocks-tooltip Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kevinb-khan kevinb-khan requested a review from a team April 29, 2025 16:12
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/wonder-blocks for changes to .changeset/moody-spies-behave.md, packages/wonder-blocks-icon/src/components/phosphor-icon.tsx, packages/wonder-blocks-icon/src/components/__tests__/phosphor-icon.test.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Apr 29, 2025

Size Change: 0 B

Total Size: 89.2 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-accordion/dist/es/index.js 2.98 kB
packages/wonder-blocks-announcer/dist/es/index.js 1.74 kB
packages/wonder-blocks-banner/dist/es/index.js 1.42 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.91 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 723 B
packages/wonder-blocks-button/dist/es/index.js 3.42 kB
packages/wonder-blocks-cell/dist/es/index.js 2.06 kB
packages/wonder-blocks-clickable/dist/es/index.js 2.65 kB
packages/wonder-blocks-core/dist/es/index.js 2.45 kB
packages/wonder-blocks-data/dist/es/index.js 5.48 kB
packages/wonder-blocks-dropdown/dist/es/index.js 16.7 kB
packages/wonder-blocks-form/dist/es/index.js 5.01 kB
packages/wonder-blocks-grid/dist/es/index.js 1.24 kB
packages/wonder-blocks-icon-button/dist/es/index.js 1.89 kB
packages/wonder-blocks-icon/dist/es/index.js 690 B
packages/wonder-blocks-labeled-field/dist/es/index.js 1.2 kB
packages/wonder-blocks-layout/dist/es/index.js 1.63 kB
packages/wonder-blocks-link/dist/es/index.js 1.62 kB
packages/wonder-blocks-modal/dist/es/index.js 4.98 kB
packages/wonder-blocks-pill/dist/es/index.js 1.31 kB
packages/wonder-blocks-popover/dist/es/index.js 4.29 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.48 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.09 kB
packages/wonder-blocks-styles/dist/es/index.js 451 B
packages/wonder-blocks-switch/dist/es/index.js 1.71 kB
packages/wonder-blocks-tabs/dist/es/index.js 1.63 kB
packages/wonder-blocks-testing-core/dist/es/index.js 3.51 kB
packages/wonder-blocks-testing/dist/es/index.js 985 B
packages/wonder-blocks-theming/dist/es/index.js 577 B
packages/wonder-blocks-timing/dist/es/index.js 1.37 kB
packages/wonder-blocks-tokens/dist/es/index.js 2.79 kB
packages/wonder-blocks-toolbar/dist/es/index.js 889 B
packages/wonder-blocks-tooltip/dist/es/index.js 6.43 kB
packages/wonder-blocks-typography/dist/es/index.js 905 B

compressed-size-action

Copy link
Contributor

github-actions bot commented Apr 29, 2025

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (2c8fa11) and published all packages with changesets to npm.

You can install the packages in webapp by running:

./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2573"

Packages can also be installed manually by running:

pnpm add @khanacademy/wonder-blocks-<package-name>@PR2573

Copy link
Member

@jandrade jandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks for the quick fix 🚢

Copy link
Member

@beaesguerra beaesguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this and fixing this! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants