Skip to content

Minor tweaks for Tabs stories #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025
Merged

Minor tweaks for Tabs stories #2674

merged 3 commits into from
Jun 25, 2025

Conversation

beaesguerra
Copy link
Member

@beaesguerra beaesguerra commented Jun 19, 2025

Summary:

  • Set aria-label on Tabs for stories using StateSheet (related thread
  • Update name property in StateSheet to include the row label, column label, and the state
  • Disable flaky zoom Tabs story

Issue: WB-XXXX

Test plan:

  • Confirm tablist element in Tabs have unique aria labels in the testing stories:
    • ?path=/story/packages-tabs-tabs-testing-tabs-snapshots--state-sheet-story
    • ?path=/story/packages-tabs-tabs-testing-tabs-snapshots--scenarios

Copy link

changeset-bot bot commented Jun 19, 2025

🦋 Changeset detected

Latest commit: b162109

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 19, 2025

Size Change: 0 B

Total Size: 101 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-accordion/dist/es/index.js 2.99 kB
packages/wonder-blocks-announcer/dist/es/index.js 1.74 kB
packages/wonder-blocks-badge/dist/es/index.js 1.75 kB
packages/wonder-blocks-banner/dist/es/index.js 1.91 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.91 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 723 B
packages/wonder-blocks-button/dist/es/index.js 4.12 kB
packages/wonder-blocks-cell/dist/es/index.js 2.06 kB
packages/wonder-blocks-clickable/dist/es/index.js 2.67 kB
packages/wonder-blocks-core/dist/es/index.js 2.48 kB
packages/wonder-blocks-data/dist/es/index.js 5.48 kB
packages/wonder-blocks-dropdown/dist/es/index.js 16.6 kB
packages/wonder-blocks-form/dist/es/index.js 4.94 kB
packages/wonder-blocks-grid/dist/es/index.js 1.24 kB
packages/wonder-blocks-icon-button/dist/es/index.js 3.05 kB
packages/wonder-blocks-icon/dist/es/index.js 2.02 kB
packages/wonder-blocks-labeled-field/dist/es/index.js 2.92 kB
packages/wonder-blocks-layout/dist/es/index.js 1.63 kB
packages/wonder-blocks-link/dist/es/index.js 1.64 kB
packages/wonder-blocks-modal/dist/es/index.js 4.99 kB
packages/wonder-blocks-pill/dist/es/index.js 1.31 kB
packages/wonder-blocks-popover/dist/es/index.js 4.32 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.48 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.09 kB
packages/wonder-blocks-styles/dist/es/index.js 467 B
packages/wonder-blocks-switch/dist/es/index.js 1.55 kB
packages/wonder-blocks-tabs/dist/es/index.js 3.67 kB
packages/wonder-blocks-testing-core/dist/es/index.js 3.51 kB
packages/wonder-blocks-testing/dist/es/index.js 985 B
packages/wonder-blocks-theming/dist/es/index.js 577 B
packages/wonder-blocks-timing/dist/es/index.js 1.37 kB
packages/wonder-blocks-tokens/dist/es/index.js 4.84 kB
packages/wonder-blocks-toolbar/dist/es/index.js 900 B
packages/wonder-blocks-tooltip/dist/es/index.js 6.42 kB
packages/wonder-blocks-typography/dist/es/index.js 1.15 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Jun 19, 2025

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-ojbpvqbavf.chromatic.com/

Chromatic results:

Metric Total
Captured snapshots 364
Tests with visual changes 2
Total stories 637
Inherited (not captured) snapshots [TurboSnap] 28
Tests on the build 392

@beaesguerra beaesguerra marked this pull request as ready for review June 19, 2025 23:09
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/wonder-blocks for changes to .changeset/breezy-shrimps-teach.md, __docs__/components/state-sheet.tsx, __docs__/wonder-blocks-tabs/tabs-testing-snapshots.stories.tsx, __docs__/wonder-blocks-tabs/tabs-utils.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team June 19, 2025 23:09
Copy link
Contributor

npm Snapshot: NOT Published

🤕 Oh noes!! We couldn't find any changesets in this PR (a1e5d07). As a result, we did not publish an npm snapshot for you.

Copy link
Member

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@beaesguerra beaesguerra merged commit a9aa604 into main Jun 25, 2025
22 checks passed
@beaesguerra beaesguerra deleted the sb-tweaks branch June 25, 2025 17:12
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (1d3b761) to head (b162109).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@     Coverage Diff      @@
##   main   #2674   +/-   ##
============================
============================

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3b761...b162109. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants