Don't open a browser when $DISPLAY is not set #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually, when pressing enter, GDB will repeat the last command. This can be very useful for commands like "next". But for "jsdbg", this is not ideal, especially when the user presses enter to get back to the GDB prompt after the text from jsdbg has been printed. This patch suppresses that behavior.
E.g. when connected via SSH to a remote host (without X forwarding). Otherwise, Python's webbrowser module will open a browser like elinks, taking you out of GDB. This also prints instructions for setting up SSH port forwarding.
sanketj
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also prints some instructions for setting up SSH port forwarding.
I've also used this opportunity to set things up such that pressing Enter will
not repeat the jsdbg command.