-
Notifications
You must be signed in to change notification settings - Fork 57
Add Spec: Critical Kill Switch #4574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dianaqu
merged 10 commits into
user/xiaqu/critical-kill-switch
from
dianaqu/critical-switch-draft
Jul 1, 2024
Merged
Add Spec: Critical Kill Switch #4574
dianaqu
merged 10 commits into
user/xiaqu/critical-kill-switch
from
dianaqu/critical-switch-draft
Jul 1, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-risney
requested changes
May 21, 2024
Co-authored-by: David Risney <dave@deletethis.net>
Co-authored-by: David Risney <dave@deletethis.net>
Co-authored-by: David Risney <dave@deletethis.net>
david-risney
reviewed
Jul 1, 2024
david-risney
reviewed
Jul 1, 2024
david-risney
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for the two issues mentioned. Please fix those and let me know when you have a PR to main and I will schedule a review.
dianaqu
added a commit
that referenced
this pull request
Jul 11, 2024
* Add Spec: Critical Kill Switch (#4574) * add critical api --------- Co-authored-by: Diana Qu <xiaqu@microsoft.com> Co-authored-by: David Risney <dave@deletethis.net> * Sample code update Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> * Fix typo Co-authored-by: Viktoria Zlatinova <vizlatin@microsoft.com> * renaming API and update doc * renaming md file --------- Co-authored-by: Diana Qu <xiaqu@microsoft.com> Co-authored-by: David Risney <dave@deletethis.net> Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com> Co-authored-by: Viktoria Zlatinova <vizlatin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add spec for critical kill switch