Skip to content

Add Spec: Critical Kill Switch #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dianaqu
Copy link
Contributor

@dianaqu dianaqu commented May 21, 2024

Add spec for critical kill switch

@dianaqu dianaqu requested a review from david-risney May 21, 2024 00:16
dianaqu and others added 2 commits May 21, 2024 13:32
Co-authored-by: David Risney <dave@deletethis.net>
dianaqu and others added 4 commits June 12, 2024 14:23
Co-authored-by: David Risney <dave@deletethis.net>
Co-authored-by: David Risney <dave@deletethis.net>
Copy link
Contributor

@david-risney david-risney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the two issues mentioned. Please fix those and let me know when you have a PR to main and I will schedule a review.

@dianaqu dianaqu merged commit a0ac76e into user/xiaqu/critical-kill-switch Jul 1, 2024
1 check passed
dianaqu added a commit that referenced this pull request Jul 11, 2024
* Add Spec: Critical Kill Switch (#4574)

* add critical api

---------

Co-authored-by: Diana Qu <xiaqu@microsoft.com>
Co-authored-by: David Risney <dave@deletethis.net>

* Sample code update

Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com>

* Fix typo

Co-authored-by: Viktoria Zlatinova <vizlatin@microsoft.com>

* renaming API and update doc

* renaming md file

---------

Co-authored-by: Diana Qu <xiaqu@microsoft.com>
Co-authored-by: David Risney <dave@deletethis.net>
Co-authored-by: MikeHillberg <18429489+MikeHillberg@users.noreply.github.com>
Co-authored-by: Viktoria Zlatinova <vizlatin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants