Skip to content

API Review: PostWebMessageAsJson and PostWebMessageAsString APIs for workers #5170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

dhveerap
Copy link
Contributor

This is a review for the new PostWebMessageAsJson and PostWebMessageAsString APIs for dedicated and service workers.

…workers (#5151)

This is a review for the new PostWebMessageAsJson and PostWebMessageAsString APIs for dedicated and service workers.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@AshleyScirra
Copy link

It might be useful to expose the name of dedicated workers (i.e. the name specified by new Worker(url, { name }). This would provide a way to identify a specific worker without needing to depend on the script URL.

Copy link
Contributor

@david-risney david-risney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see feedback. Thanks!

@dhveerap dhveerap requested a review from david-risney June 17, 2025 14:14
@dhveerap dhveerap merged commit ba3f47a into main Jun 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Proposal Review WebView2 API Proposal for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants