-
Notifications
You must be signed in to change notification settings - Fork 184
feat(app): Show labware versions in LPC #18870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18870 +/- ##
==========================================
+ Coverage 24.34% 25.41% +1.06%
==========================================
Files 3312 3333 +21
Lines 289304 291502 +2198
Branches 30805 30839 +34
==========================================
+ Hits 70432 74085 +3653
+ Misses 218851 217390 -1461
- Partials 21 27 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Groovy!
}: AccordionHeaderProps): JSX.Element { | ||
const { t } = useTranslation('labware_position_check') | ||
const offsetCopy = useSelector( | ||
selectTotalOrMissingOffsetRequiredCountForLwCopy(runId, uri, t as TFunction) | ||
) | ||
const isOnDevice = useSelector(getIsOnDevice) | ||
const nameString = isOnDevice | ||
? truncateString(lwDisplayName, 43) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not just here, but in general in the places where we use truncateString()
, why would we truncate to a hard-coded length instead of using CSS text-overflow: ellipsis
? Won't this cause problems with letter size variability? Or even just general maintainability as things in the designs get resized over time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it does have problems with letter size variability, which requires erring on the side of caution. I can't speak to all our usages in the app, but I generally use it in spots where designs don't sufficiently indicate how child content ought to be partitioned in a parent container (ex, the labware naming bounding box vs version bounding box).
Closes EXEC-1592
Overview
Sometimes, when users start protocol setup, it appears as if labware that had offsets in the past now have missing offsets. In actuality, the protocol run utilizes a different version of labware than was previously set in LPC, and offsets are tied to labware versions.
After discussion with Product and Design, we've decided to surface labware versions, which provide some level of visual indication that helps point users to a reason why labware offsets that were present in a past run are now missing.
Protocol Setup
LPC Labware List
Test Plan and Hands on Testing
Changelog
Risk assessment
none, just copy