-
Notifications
You must be signed in to change notification settings - Fork 183
feat(hardware-testing,api,shared-data): Add TOF-Analysis tool to generate, plot, and validate baselines and measurements + related improvements. #18875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… more data analysis
…module where they are used
update baseline to std = 5 5 5 5
- use direction in `verify_hopper_labware_presence`
add plots to README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I hope we get a second pass at the thresholding someday.
Co-authored-by: Seth Foster <seth@opentrons.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18875 +/- ##
==========================================
- Coverage 25.39% 23.79% -1.61%
==========================================
Files 3333 3333
Lines 287572 287598 +26
Branches 36508 35907 -601
==========================================
- Hits 73042 68433 -4609
- Misses 214507 219139 +4632
- Partials 23 26 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
add type hints :\
…pentrons/opentrons into flex-stacker-tof-data-analysis
Overview
This pull request consolidates the TOF sensor tooling scattered across various branches into a single
tof-analysis
tool. This tool lets you generate baselines, plot baselines + measurements, and validate baselines for labware detection. It updates the baseline format to include version and platform for each baseline, and generates new baselines in theFlexStackerModuleV1.json
file using over 1800 new measurement samples to greatly increase labware detection accuracy. There are a lot of file changes, but that's from moving the stacker QC tests into astacker
directory.plus a few other cleanup changes.
TOF-Analysis Tool
Test Plan and Hands on Testing
Changelog
flex_stacker.py
file, which is the only place that uses them.Review requests
Risk assessment