Pipeline updates #232
Merged
Pipeline updates #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Hixie asked me to apply this change. Should be editorial.
| @@ -503,7 +503,7 @@ was an English <a href="/wiki/Music_hall">music hall</a> singer, ...</pre> | |||
|
|
|||
| <li><p>A <code data-x="attr-picture-source-media">media</code> attribute specified with a value that, | |||
| after <span data-x="strip leading and trailing whitespace">stripping leading and trailing whitespace</span>, | |||
| is not the empty string and is not an <span>ASCII case-insensitive</span> match for the string <code>all</code>.</p></li> | |||
| is not the empty string and is not an <span>ASCII case-insensitive</span> match for the string "<code data-x="">all</code>".</p></li> | |||
There was a problem hiding this comment.
Is it intentional that this appears to be the sole diff line that is adding a data-x="" attribute?
There was a problem hiding this comment.
Long-term, the keyword "all" should just be defined as a term and cross-referenced. The data-x="" here is just making sure that it doesn't end up cross-referencing to something else later if there's ever a all added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Hixie asked me to apply this change. Should be editorial.