Remove deprecated preserveUnknownFields from CRDs #4135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahatzz11
requested review from
mumoshu,
toast-gear,
nikola-jokic,
rentziass and
a team
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated preserveUnknownFields field from several CRD configurations to align with the updated Argo guidelines in version 3.0.
- Removal of preserveUnknownFields from actions.github.com_ephemeralrunnersets.yaml
- Removal of preserveUnknownFields from actions.github.com_ephemeralrunners.yaml
- Removal of preserveUnknownFields from actions.github.com_autoscalingrunnersets.yaml
- Removal of preserveUnknownFields from actions.github.com_autoscalinglisteners.yaml
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| config/crd/bases/actions.github.com_ephemeralrunnersets.yaml | Removed deprecated preserveUnknownFields field |
| config/crd/bases/actions.github.com_ephemeralrunners.yaml | Removed deprecated preserveUnknownFields field |
| config/crd/bases/actions.github.com_autoscalingrunnersets.yaml | Removed deprecated preserveUnknownFields field |
| config/crd/bases/actions.github.com_autoscalinglisteners.yaml | Removed deprecated preserveUnknownFields field |
ahatzz11
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use argo to manage our deployment of ARC. We recently upgraded to 3.0, where they removed a default setting to ignore the
preserveUnknownFieldsfields being mismatched. From their docs:To solve for this now out-of-sync CRD in argo I did enable this ignore rule globally on our argo, but because of this deprecation and the number of people who seem to use argo to manage their ARC installations, I thought I'd contribute back upstream to help ensure argo users show a properly synced ARC by removing this deprecated field.
Here is how our ARC installation looks in argo without ignoring this field while it's present in the CRD:
