[Windows-2025] Enable permission inheritance for the C: drive #12467
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a step to enable permission inheritance on the entire C:\ drive in the Windows-2025 image.
- Added a conditional block that runs the icacls command to modify inheritance settings.
- Includes error handling to throw an exception if enabling inheritance fails.
| @@ -36,6 +36,14 @@ if ($LASTEXITCODE -ne 0) { | |||
| throw "Failed to grant Users full control of $env:SystemRoot\Temp" | |||
| } | |||
|
|
|||
| # Enable inheritance for the entire C:\ drive | |||
| if (Test-IsWin25) { | |||
| cmd /c "icacls C:\ /inheritance:e /c /q 2>&1" | Out-Null | |||
There was a problem hiding this comment.
Consider capturing and logging the output of the icacls command rather than discarding it. This would help with troubleshooting if the inheritance change fails.
Copilot uses AI. Check for mistakes.
paveliak
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request enables inheritance for the entire `C: drive in the Windows-2025 image.
Related issue:
https://github.com/github/c2c-actions-support/issues/4894
Check list