[Windows] Stop pinning of Visual Studio version #12469
Open
+7
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the hard-pinned Visual Studio channel URI so that the runner images will install whatever version is provided by postGRO by default.
- Dropped the
installChannelfield from both Windows 2022 and 2025 toolset JSON configs - Removed the
InstallChannelparameter and related logic in theInstall-VisualStudiohelper - Simplified the build script to call
Install-VisualStudiounconditionally, removing OS-specific branches
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| images/windows/toolsets/toolset-2025.json | Removed pinned InstallChannel from VS toolset config |
| images/windows/toolsets/toolset-2022.json | Removed pinned InstallChannel from VS toolset config |
| images/windows/scripts/helpers/VisualStudioHelpers.ps1 | Dropped InstallChannel parameter and updated URI logic |
| images/windows/scripts/build/Install-VisualStudio.ps1 | Simplified install script by removing OS conditionals |
Comments suppressed due to low confidence (2)
images/windows/scripts/helpers/VisualStudioHelpers.ps1:18
- [nitpick] Review the function help block and any examples to ensure all references to the now-removed
InstallChannelparameter are cleaned up.
.PARAMETER RequiredComponents
images/windows/scripts/build/Install-VisualStudio.ps1:7
- [nitpick] Adjust the indentation of this unconditional
Install-VisualStudiocall to align with the script's top-level formatting now that theifblocks have been removed.
Install-VisualStudio `
| @@ -45,7 +41,7 @@ Function Install-VisualStudio { | |||
| $channelUri = "https://aka.ms/vs/${Version}/${Channel}/channel" | |||
| $channelId = "VisualStudio.${Version}.Release" | |||
| $productId = "Microsoft.VisualStudio.Product.${Edition}" | |||
| $installChannelUri = "https://aka.ms/vs/${Version}/${Channel}/${installchannel}/channel" | |||
| $installChannelUri = "https://aka.ms/vs/${Version}/${Channel}/channel" | |||
There was a problem hiding this comment.
Remove the trailing whitespace at the end of this line to avoid unintended whitespace in the constructed URI.
Suggested change
| $installChannelUri = "https://aka.ms/vs/${Version}/${Channel}/channel" | |
| $installChannelUri = "https://aka.ms/vs/${Version}/${Channel}/channel" |
Copilot uses AI. Check for mistakes.
paveliak
reviewed
Jun 24, 2025
paveliak
approved these changes
Jun 25, 2025
paveliak
requested changes
Jun 25, 2025
There was a problem hiding this comment.
Let's have a chat in context of https://developercommunity.visualstudio.com/t/Code-optimization-bug-SIMD-std::transf/10912292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Change proposes to remove the pinned version of Visual Studio from the
windows-2022andwindows-2025runner images.The version available in the
postGROshould automatically get installed into the runner images, without any manual intervention.Related issue:
https://github.com/github/hosted-runners-images/issues/116
Check list