Change explorer panel styling #348
Conversation
sn2912
requested review from
bwieger-atlassian-com,
sdzh-atlassian,
cabella-dot,
marcomura,
akalia-atlassian and
pastelsky
as code owners
| @@ -33,4 +34,6 @@ export function activate(context: ExtensionContext) { | |||
| copyPullRequest.run(), | |||
| ); | |||
| context.subscriptions.push(copyPullRequestCmd); | |||
| const decorationProvider = new FileDecorationProvider(); | |||
There was a problem hiding this comment.
why are you registering this with the commands?
There was a problem hiding this comment.
I had added since I wanted to register the decoration provider when extension activates.
But my bad, have refactored the code to separate UI decorations from commands
| @@ -1,8 +1,9 @@ | |||
| import { commands, ExtensionContext } from 'vscode'; | |||
| import { commands, ExtensionContext, window } from 'vscode'; | |||
There was a problem hiding this comment.
Where is window used?
There was a problem hiding this comment.
On line 42 to register the decoration provider
| import { CopyBitbucketPullRequestCommand } from './command-copy-pullreqest'; | ||
| import { OpenInBitbucketCommand } from './command-open'; | ||
| import { OpenBitbucketChangesetCommand } from './command-open-changeset'; | ||
| import { OpenBitbucketPullRequestCommand } from './command-open-pullrequest'; | ||
| import { FileDecorationProvider } from 'src/views/nodes/pullRequestFilesNode'; |
There was a problem hiding this comment.
Are src/ URLs working in the extension?
There was a problem hiding this comment.
Yeah they are, I didn't have idea about reasons for not using them.
Any specific cons?
| @@ -68,28 +123,14 @@ export class PullRequestFilesNode extends AbstractBaseNode { | |||
| title: 'Diff file', | |||
| arguments: this.diffViewData.diffArgs, | |||
| }; | |||
|
|
|||
| item.contextValue = `${PullRequestContextValue}${this.checked ? '.checked' : ''}`; | |||
There was a problem hiding this comment.
Are these not changes from the previous PR?
There was a problem hiding this comment.
No these are expected to be part of this PR itself to remove these icons
sn2912
force-pushed
the
change-explorer-panel-styling
branch
from
0dd20d0 to
5b92062
Compare
What Is This Change?
This PR includes styling changes around displaying filenames in bitbucket pullrequest explorer panel,
How Has This Been Tested?
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations: