Add Java support #88
Merged
Add Java support #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is fantastic! Great query and excellent test cases. Thank you for doing this. I'll merge this once CI runs. I'll need to make an update to the Zed extension to add Java, but I'll get that out once this lands. |
|
Sure thing! Thanks a bunch for making it super easy for beginners to contribute! |
|
Great, I just released the new Language Server with Java support. It's going to be a little wonky until the Zed extension is updated as well, but waiting on Zed to merge: zed-industries/extensions#2975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Java spell checking :)
The tree-sitter queries created in
./crates/codebook/src/queries/java.scmwere built using the resources below:I also created some tests which should cover most scenarios where spell checking is desirable and undesirable. Here are the paths to the files created from the project root:
./crates/codebook/tests/test_java.rs./crates/codebook/tests/examples/example.javaI didn't test the
example.javafile because I didn't update the extension with the changes I made but I did testtest_java.rsby running the following command:$ cargo test -p codebook queries::tests::test_all_queries_are_validThe test passed! If anyone sees any issues with the tests please go ahead and update them or leave a comment and I can change it!