[Android] Keyboard navigation does not work with RadioButtons with redefined appearance #30041
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defined appearance
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the bug where RadioButton controls with a redefined ControlTemplate were not fully keyboard-navigable on Android. Key changes include:
- Adding a property to store the ContentViewGroup and subscribing to its KeyPress event.
- Removing existing content views and re-adding the presented content.
- Implementing a key press handler to toggle the radio button state on Enter/Space key presses.
Comments suppressed due to low confidence (1)
src/Controls/src/Core/RadioButton/RadioButton.Android.cs:7
- [nitpick] Consider renaming the property 'contentViewGroup' to 'ContentViewGroup' to follow .NET PascalCase naming conventions for properties.
ContentViewGroup? contentViewGroup { get; set; }
| if (e?.Event is not null && e.Event.Action == Android.Views.KeyEventActions.Down && | ||
| (e.Event.KeyCode == Android.Views.Keycode.Enter || e.Event.KeyCode == Android.Views.Keycode.Space)) | ||
| { | ||
| IsChecked = !IsChecked; |
There was a problem hiding this comment.
After toggling 'IsChecked' on key press, consider setting 'e.Handled = true' within this block to prevent further propagation of the key event.
Suggested change
| IsChecked = !IsChecked; | |
| IsChecked = !IsChecked; | |
| e.Handled = true; |
Copilot uses AI. Check for mistakes.
kubaflo
added
area-controls-radiobutton
jsuarezruiz
requested changes
Jun 18, 2025
|
I will add a test once we decide if this PR makes sense or we should take a different approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This PR fixes a bug where RadioButton controls using a ControlTemplate do not support keyboard navigation (using arrow keys or Tab), breaking the expected accessibility behavior.
When a ControlTemplate is applied, the internal focusable or input-handling elements may be bypassed or not properly initialized for keyboard interaction. This change ensures that:
Issues Fixed
Fixes #30040
Screen.Recording.2025-06-18.at.01.04.47.mov
Screen.Recording.2025-06-18.at.01.07.13.mov