[iOS/MacOs] Right-To-Left (RTL) alignment is not applied to Editor placeholder - fix #30057
+56
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
A fix to ensure the Editor placeholder on iOS/MacOS respects RTL alignment by copying the semantic content attribute and text alignment from the main control.
- Set
SemanticContentAttributeandTextAlignmenton the placeholder label inUpdatePlaceholderLabelFrame
Comments suppressed due to low confidence (2)
src/Core/src/Platform/iOS/MauiTextView.cs:149
- [nitpick] Consider adding unit tests to verify that the placeholder label correctly applies the semantic content attribute and text alignment in both LTR and RTL layouts.
_placeholderLabel.SemanticContentAttribute = SemanticContentAttribute;
src/Core/src/Platform/iOS/MauiTextView.cs:151
- The stray '};' at the end of the method appears to be a typo and will cause a compile error. It should likely be a single '}' without the semicolon.
};
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
kubaflo
added
area-controls-editor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
requested changes
Jun 20, 2025
| public void RTLShouldBeAppliedToPlaceholers() | ||
| { | ||
| App.WaitForElement("Editor"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Pending snapshots already available on the latest build.
Could you commit the images?
| Content = new VerticalStackLayout | ||
| { | ||
| FlowDirection = FlowDirection.RightToLeft, | ||
| Children = |
There was a problem hiding this comment.
Could the test also verify changes at runtime? like change the FlowDirection tapping a Button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issues Fixed
Fixes #30052